-
Notifications
You must be signed in to change notification settings - Fork 301
use github app #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use github app #666
Conversation
|
|
📚 Documentation sync PR: cloudflare/cloudflare-docs#26640 This comment is automatically updated when the PR changes. Generated by Claude Code for the Cloudflare Agents team |
commit: |
11323b4 to
16a5da5
Compare
0533da6 to
5469972
Compare
Synced from cloudflare/agents PR #666 cloudflare/agents#666
Claude Code ReviewSummaryThis PR migrates from Personal Access Token (PAT) to GitHub App authentication. The changes are clean and improve security by using time-limited tokens with granular permissions. Issues Found1. Critical: Step 8 removal creates incomplete workflow (sync-docs.yml:150) The PR removes Step 8 which comments on the original PR with the docs sync PR link. This breaks the user feedback loop - PR authors won't know that a docs PR was created. The step should be retained or replaced with equivalent functionality. 2. Placeholder script needs automation (sync-docs.yml:125-148) The script still requires manual replacement of PLACEHOLDER values: PR_NUMBER="PLACEHOLDER_PR_NUMBER"
PR_TITLE="PLACEHOLDER_PR_TITLE"
PR_URL="PLACEHOLDER_PR_URL"These should use the actual context variables like: PR_NUMBER=""
PR_TITLE=""
PR_URL=""Without this fix, Claude will need to manually substitute these values, which is error-prone. 3. Token consistency issue (release.yml:47)
Recommendations
The core migration is sound, but these issues need resolution before merge. |
move from PAT to github-app