Skip to content

Conversation

@steve-thousand
Copy link
Contributor

@steve-thousand steve-thousand commented Nov 10, 2025

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  1. Fixing policy order by removing unnecessary computed fields and switching to a set
  2. Changing resources to a string so that we can use jsonencode to represent more complex resource forms

Acceptance test run results

  • I have run acceptance tests for my changes and included the results below
TF_ACC=1 go test internal/services/account_token/resource_test.go
ok      command-line-arguments  180.053s
TF_ACC=1 go test internal/services/api_token/resource_test.go    
ok      command-line-arguments  278.908s

Additional context & links

The changes to resources will result in a backwards-compatibility breaking change, but we were unable to find a better way to support polymorphic resources. Users who already have tokens will need to wrap their resources definition in a jsonencode function call.

Example previous config:

resources = {
  "com.cloudflare.api.account.ABC" = "*"
}

New conifg with added jsonencode

resources = jsonencode({
  "com.cloudflare.api.account.ABC" = "*"
})

We did also verify that removing the computed fields shouldn't cause any issues for users with existing state files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant