fix: Generalize autoconfig wording (#11249)

* fix: Generalize autoconfig wording

* Add test for when no output directory is in the autoconfig details

* update error message as suggested

Author: dario-piotrowicz

.changeset/salty-games-push.md

@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+fix: Generalize autoconfig wording
+
+Generalize the autoconfig wording so that when it doesn't specifically mention "deployment" (since it can be run via `wrangler setup` or the autoconfig programmatic API)

packages/wrangler/src/__tests__/autoconfig/run.test.ts

@@ -340,5 +340,24 @@ describe("autoconfig (deploy)", () => {
 				"
 			`);
 		});
+
+		it("errors if no output directory is specified in the autoconfig details", async () => {
+			mockConfirm({
+				text: "Do you want to modify these settings?",
+				result: false,
+			});
+
+			await expect(
+				run.runAutoConfig({
+					projectPath: process.cwd(),
+					configured: false,
+					framework: new Static("static"),
+					workerName: "my-worker",
+					outputDir: "",
+				})
+			).rejects.toThrowErrorMatchingInlineSnapshot(
+				`[Error: Cannot configure project without an output directory]`
+			);
+		});
 	});
 });

packages/wrangler/src/autoconfig/run.ts

@@ -59,7 +59,9 @@ export async function runAutoConfig(
 	autoConfigDetails = updatedAutoConfigDetails;
 
 	if (!autoConfigDetails.outputDir) {
-		throw new FatalError("Cannot deploy project without an output directory");
+		throw new FatalError(
+			"Cannot configure project without an output directory"
+		);
 	}
 
 	const wranglerConfig: RawConfig = {
@@ -82,7 +84,7 @@ export async function runAutoConfig(
 	});
 
 	if (!(skipConfirmations || (await confirm("Proceed with setup?")))) {
-		throw new FatalError("Deployment aborted");
+		throw new FatalError("Setup cancelled");
 	}
 
 	if (dryRun) {