Ensure that wrangler deploy --dry-run doesn't fetch data from the rest API (#11465)

Author: dario-piotrowicz

packages/wrangler/src/__tests__/deploy.test.ts

@@ -15285,6 +15285,32 @@ export default{
 			`);
 		});
 
+		it("should not present a diff warning to the user when there are differences between the local config (json/jsonc) and the dash config in dry-run mode", async () => {
+			writeWorkerSource();
+			writeWranglerConfig(
+				{
+					compatibility_date: "2024-04-24",
+					main: "./index.js",
+					workers_dev: true,
+					preview_urls: true,
+					vars: {
+						MY_VAR: 123,
+					},
+					observability: {
+						enabled: true,
+					},
+				},
+				"./wrangler.json"
+			);
+
+			// Note: we don't set any mocks here since in dry-run we don't expect wragnler to interact
+			//       with the rest API in any way
+
+			await runWrangler("deploy --dry-run");
+
+			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`""`);
+		});
+
 		it("should present a diff warning to the user when there are differences between the local config (toml) and the dash config", async () => {
 			writeWorkerSource();
 			mockGetServiceByName("test-name", "production", "dash");
@@ -15599,13 +15625,43 @@ export default{
 
 			await runWrangler("deploy");
 
+			expect(fetchSecrets).toHaveBeenCalled();
 			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`
 				"▲ [WARNING] Environment variable \`MY_SECRET\` conflicts with an existing remote secret. This deployment will replace the remote secret with your environment variable.
 
 				"
 			`);
 		});
 
+		it("should not fetch remote secrets in dry-run mode", async () => {
+			writeWorkerSource();
+			writeWranglerConfig(
+				{
+					compatibility_date: "2024-04-24",
+					main: "./index.js",
+					vars: {
+						MY_SECRET: 123,
+					},
+					observability: {
+						enabled: true,
+					},
+				},
+				"./wrangler.json"
+			);
+
+			// Note: we don't set any mocks here since in dry-run we don't expect wragnler to interact
+			//       with the rest API in any way
+
+			vi.mocked(fetchSecrets).mockResolvedValue([
+				{ name: "MY_SECRET", type: "secret_text" },
+			]);
+
+			await runWrangler("deploy --dry-run");
+
+			expect(fetchSecrets).not.toHaveBeenCalled();
+			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`""`);
+		});
+
 		it("should abort the deployment when it would (likely unintentionally) override remote secrets in non-interactive strict mode", async () => {
 			setIsTTY(false);
 
@@ -15652,6 +15708,8 @@ export default{
 
 			await runWrangler("deploy --strict");
 
+			expect(fetchSecrets).toHaveBeenCalled();
+
 			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`
 				"▲ [WARNING] Environment variable \`MY_SECRET\` conflicts with an existing remote secret. This deployment will replace the remote secret with your environment variable.
 

packages/wrangler/src/deploy/deploy.ts

@@ -473,7 +473,7 @@ export default async function deploy(props: Props): Promise<{
 		}
 	}
 
-	if (isInteractive() || props.strict) {
+	if (accountId && (isInteractive() || props.strict)) {
 		const remoteSecretsCheck = await checkRemoteSecretsOverride(
 			config,
 			props.env