Use autoconfig in c3 #11251

penalosa · 2025-11-12T21:22:51Z

Fixes https://jira.cfdata.org/browse/DEVX-2313

This repurposes the existing C3 --experimental flag (which has associated filtering, logging and separate test runs) to configure frameworks with autoconfig (via wrangler setup) instead of using the existing C3 logic. Over time, this will expand to more frameworks, at which point autoconfig will become the default C3 flow

Tests
- Tests included
- Tests not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: tracked elsewhere
Wrangler V3 Backport
- Wrangler PR:
- Not necessary because: not a v3 feature

changeset-bot · 2025-11-12T21:22:55Z

🦋 Changeset detected

Latest commit: 923d457

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

penalosa · 2025-11-12T21:27:48Z

packages/wrangler/src/autoconfig/run.ts

 		`Running autoconfig with:\n${JSON.stringify(autoConfigDetails, null, 2)}...`
 	);

-	startSection("Configuring your application for Cloudflare");


This output was a bit verbose

penalosa · 2025-11-12T21:28:19Z

packages/wrangler/src/package-manager.ts

-	logger.log({
-		hasYarn,
-		hasNpm,
-		hasPnpm,
-		hasBun,
-	});


@MattieTK I think this was a stray debugging log that got merged

penalosa · 2025-11-12T21:28:33Z

packages/wrangler/src/package-manager.ts

 	// check the user agent
 	if (userAgent === "npm" && hasNpm) {
-		logger.log("Using npm as package manager.");
+		logger.debug("Using npm as package manager.");


These being .log() was getting very noisy

penalosa · 2025-11-12T21:29:19Z

packages/wrangler/src/setup.ts

 		// Only run auto config if the project is not already configured
 		if (!details.configured) {
-			await runAutoConfig(details);
+			await runAutoConfig(details, { skipBuild: true });


wrangler setup shouldn't really be running a build, in my opinion.

pkg-pr-new · 2025-11-12T21:34:40Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11251

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11251

miniflare

npm i https://pkg.pr.new/miniflare@11251

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11251

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11251

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11251

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11251

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11251

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11251

wrangler

npm i https://pkg.pr.new/wrangler@11251

commit: 923d457

… & C3

…hould be 3 mins

…meworks we were injecting extra dev commands into package.json files, which meant that generated C3 projects often had both a `start` and a `develop` script.

packages/wrangler/src/wrangler-banner.ts

packages/wrangler/src/setup.ts

dario-piotrowicz · 2025-11-13T10:42:25Z

packages/wrangler/src/autoconfig/run.ts

+			deploy:
+				autoConfigDetails.framework?.deploy ??
+				(autoConfigDetails.buildCommand
+					? `${autoConfigDetails.buildCommand} && wrangler deploy`
+					: `wrangler deploy`),
+			preview:
+				autoConfigDetails.framework?.preview ??
+				(autoConfigDetails.buildCommand
+					? `${autoConfigDetails.buildCommand} && wrangler dev`
+					: `wrangler dev`),


mh.... I am not completely sure if we should modify the deploy and preview script for the user... it feels a bit invasive 🤔

It is invasive, but I think it's the right behaviour. It matches what C3 does, and (as with all the autconfig settings), a user could roll it back if they wanted to.

a user could roll it back if they wanted to.

Yes for sure 👍

but I think it's the right behaviour

Ok, if you think so I am happy with it 🙂, it does feel a bit off to me... but it also does make sense...

Also including these scripts could be instrumental for handling the Next.js issue you raised (since our open-next adapter has its own preview and deploy commands)

packages/wrangler/src/__tests__/banner.test.ts

dario-piotrowicz · 2025-11-13T10:53:43Z

.changeset/ninety-monkeys-turn.md

+"create-cloudflare": minor
+---
+
+When the `--experimental` flag is passed to `create-cloudflare`, use `wrangler setup` for configuring a project to work on Cloudflare rather than the existing `create-cloudflare` logic. Only Gatsby is supported right now, with more frameworks to be added in future. There should be no functional change to applications created via `create-cloudflare` when using the `--experimental` flag.


I think @petebacondarwin introduced the --experimental flag in C3, I'd be keen to hear if he's ok with the flag's repurposing (or if he had in mind other potential uses for it)

Personally I'd prefer a more clear and specific flag, but I'm ok with --experimental if everyone else is

The reason I went with --experimental is that 1) it's currently not used for anything, and 2) it already has a bunch of infra set up (e.g. separate test runs) that's useful. I also think the semantic matches what we're doing here—we're changing the underlying implementation of C3 in an experimental way that we'll eventually turn on by default, which is exactly what we did with Assets.

packages/create-cloudflare/e2e/helpers/framework-helpers.ts

dario-piotrowicz · 2025-11-13T10:55:59Z

packages/create-cloudflare/e2e/helpers/framework-helpers.ts

+		// so wait up to 3 mins for the dev-server to be ready.
 		await retry(
-			{ times: 300, sleepMs: 5000 },
+			{ times: 30, sleepMs: 5000 },


why such reduction?

IMO 25 minutes is way too long. The comment above mentioned 5 minutes, but I've changed them both to be a consistent 3 minutes, since that seems sufficiently long for a build in CI

30 times 5 seconds, isn't it 150 seconds? so 2.5 minutes?

I did also comment above as the numbers here are not matching up for me 😅

(maybe I would update the comment to say so wait for some time for the dev-server to be ready. so that we don't need to over-analyze be specific on the time?)

IMO 25 minutes is way too long. The comment above mentioned 5 minutes

that's another reason as to why I would recommend to be a bit more generic with the comment, so that we avoid this sort of issues when the comment got outdate 🤔

(PS: 25 minutes does feel like a very long time, if reducing it works in CI, I'm totally happy with that)

I'll update the comment

ok, sorry for the nit 😅👍

packages/wrangler/src/autoconfig/run.ts

dario-piotrowicz

Looks great to me! 🤩

workers-devprod added this to workers-sdk Nov 12, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Nov 12, 2025

penalosa commented Nov 12, 2025

View reviewed changes

penalosa force-pushed the penalosa/c3-autoconfig branch 2 times, most recently from c91c08f to 40c72d3 Compare November 13, 2025 00:39

Support the WRANGLER_HIDE_BANNER environment variable across Wrangler…

f634b16

… & C3

penalosa force-pushed the penalosa/c3-autoconfig branch from 40c72d3 to f634b16 Compare November 13, 2025 00:43

penalosa added 4 commits November 13, 2025 00:44

Reduce C3 framework test timeout. Previously it was 25 mins, now it s…

f9bb2ba

…hould be 3 mins

Remove dev server from C3 command. To make this consistent across fra…

e81c1d4

…meworks we were injecting extra dev commands into package.json files, which meant that generated C3 projects often had both a `start` and a `develop` script.

Reduce logging in package-manager detection

26ea382

Expand autoconfig & use it in C3 for gatsby

076b75c

penalosa force-pushed the penalosa/c3-autoconfig branch from ad59ecf to 076b75c Compare November 13, 2025 00:55

Expand framework configuration and support dry-running

2f70ff4

penalosa marked this pull request as ready for review November 13, 2025 09:55

penalosa requested a review from a team as a code owner November 13, 2025 09:55

dario-piotrowicz reviewed Nov 13, 2025

View reviewed changes

penalosa added 2 commits November 13, 2025 12:03

Address comments

50183a9

Address comments

9ff1009

dario-piotrowicz approved these changes Nov 13, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 13, 2025

penalosa mentioned this pull request Nov 13, 2025

Add --dry-run flag to wrangler setup and also a dryRun option to runAutoConfig #11258

Open

6 tasks

longer timeout 😢

923d457

petebacondarwin merged commit 7035804 into main Nov 13, 2025
30 checks passed

petebacondarwin deleted the penalosa/c3-autoconfig branch November 13, 2025 14:45

github-project-automation bot moved this from Approved to Done in workers-sdk Nov 13, 2025

workers-devprod mentioned this pull request Nov 13, 2025

Version Packages #11267

Open

Use autoconfig in c3 #11251

Use autoconfig in c3 #11251

Uh oh!

Conversation

penalosa commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

penalosa commented Nov 12, 2025 •

edited

Loading

changeset-bot bot commented Nov 12, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 12, 2025 •

edited

Loading

dario-piotrowicz Nov 13, 2025 •

edited

Loading