Skip to content

Conversation

@pmiguel
Copy link
Contributor

@pmiguel pmiguel commented Jan 14, 2025

Fixes #DEVX-1551

Changes the default behaviour of wrangler kv namespace create to not prefix the worker name to the namespace name.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no contract change with target API.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: will update before v4 releases.

@pmiguel pmiguel requested review from a team as code owners January 14, 2025 13:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 4a27840

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-wrangler-7759

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7759/npm-package-wrangler-7759

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-wrangler-7759 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-workers-bindings-extension-7759 -O ./cloudflare-workers-bindings-extension.0.0.0-vf21bc453e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf21bc453e.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-create-cloudflare-7759 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-kv-asset-handler-7759

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-miniflare-7759

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-pages-shared-7759

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-unenv-preset-7759

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-vite-plugin-7759

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-vitest-pool-workers-7759

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-workers-editor-shared-7759

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-workers-shared-7759

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13399075543/npm-package-cloudflare-workflows-shared-7759

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@pmiguel pmiguel force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from 4d9828e to 3a68ef4 Compare January 20, 2025 11:27
@penalosa penalosa added this to the Wrangler v4 milestone Feb 3, 2025
@penalosa penalosa added the breaking change Change that will result in breaking existing behavior label Feb 3, 2025
@pmiguel pmiguel force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from 3a68ef4 to 7cd8429 Compare February 10, 2025 15:45
@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Feb 10, 2025
@penalosa penalosa requested a review from a team February 18, 2025 18:08
@penalosa penalosa requested review from a team as code owners February 18, 2025 18:08
@penalosa penalosa force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from 7cd8429 to f333fa6 Compare February 18, 2025 19:36
@penalosa penalosa requested a review from a team as a code owner February 18, 2025 19:47
@penalosa penalosa force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from 1ad137c to cb6a53c Compare February 18, 2025 19:54
@penalosa penalosa force-pushed the pleal/wrangler-next-drop-worker-prefix-kv-namespace branch from cb6a53c to 4a27840 Compare February 18, 2025 20:01
@penalosa penalosa merged commit d702a2f into cloudflare:next Feb 19, 2025
15 of 16 checks passed
penalosa added a commit that referenced this pull request Feb 26, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

* Remove crypto polyfill

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 6, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

* Remove crypto polyfill

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 6, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

* Remove crypto polyfill

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 7, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

* Remove crypto polyfill

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 7, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 10, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 11, 2025
* feat(wrangler): Drop worker prefix when creating KV namespaces

---------

Co-authored-by: Samuel Macleod <[email protected]>
penalosa added a commit that referenced this pull request Mar 11, 2025
* ci: setup next branch with prereleases to next tag

* chore: remove deprecated `getBindingsProxy` (#5005)

* Require Node v18 in Wrangler v4 (#7338)

* Remove node_compat in Wrangler & Miniflare v4 (#7336)

* Remove v2 warning (#7228)

* chore: update esbuild (#6884)

* `--local` by default for `wrangler kv` & `wrangler r2` (#7392)

* deprecate unused D1 commands/options  (#7471)

* chore: remove alpha support from `wrangler d1 migrations apply`

* chore: remove `wrangler d1 backups`

* chore: fixup tests

* chore: fixup tests

* chore: fixup tests

* chore: remove --batch-size

* Remove deprecated commands & config (#7352)

* Remove wrangler version

* Remove generate & strip down init

* Add changesets

* Remove deprecated --format & config

* Add changeset

* remove commands

* Fix tests

* Remove .only()

* Remove legacy assets

* clarify legacy assets -> sites naming

* various test fixes after rebase

* fixup! chore: update esbuild (#6884)

esbuild 0.24.2 variable naming changes

* fixup! Remove node_compat in Wrangler & Miniflare v4 (#7336)

* feat(wrangler): Drop worker prefix when creating KV namespaces (#7759)

* feat(wrangler): Drop worker prefix when creating KV namespaces

---------

Co-authored-by: Samuel Macleod <[email protected]>

* Include node version in name

* Ignore kv-asset-handler tests on Node 22

* rename tests

* Rename positional `json` args. Fixes #7688

* unescape

* fix tests

* Update .changeset/funny-pets-punch.md

* Add system requirements to the README

* fix formatting

* fix formatting

* Address feedback

* lockfile

* fix test

* Fix changeset format

* Use RC versioning

* feat: graduate `--x-include-runtime` (#8166)

* graduate wrangler type generation to GA

* fixups

* extra changeset

* Fix legacy assets

* Clarify that node support affects Wrangler & Miniflare & kv-asset-handler

* Clarify comment re node 20

* Add more packages

* Remove obsolete tests

* Rename legacyAssets

* more robust isLocal

* fix test snapshot

* Add --legacy-peer-deps so that installing Wrangler v4 doesn't case issues with frameworks that haven't updated their peer dependency for Wrangler v4

* Remove crypto polyfill

* fix kv.local test after rebase

* fix lockfile

* bump rc version

* revert rc versions

---------

Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: Max Rozen <[email protected]>
Co-authored-by: Pedro Leal <[email protected]>
Co-authored-by: emily-shen <[email protected]>
gabivlj pushed a commit that referenced this pull request Mar 13, 2025
* ci: setup next branch with prereleases to next tag

* chore: remove deprecated `getBindingsProxy` (#5005)

* Require Node v18 in Wrangler v4 (#7338)

* Remove node_compat in Wrangler & Miniflare v4 (#7336)

* Remove v2 warning (#7228)

* chore: update esbuild (#6884)

* `--local` by default for `wrangler kv` & `wrangler r2` (#7392)

* deprecate unused D1 commands/options  (#7471)

* chore: remove alpha support from `wrangler d1 migrations apply`

* chore: remove `wrangler d1 backups`

* chore: fixup tests

* chore: fixup tests

* chore: fixup tests

* chore: remove --batch-size

* Remove deprecated commands & config (#7352)

* Remove wrangler version

* Remove generate & strip down init

* Add changesets

* Remove deprecated --format & config

* Add changeset

* remove commands

* Fix tests

* Remove .only()

* Remove legacy assets

* clarify legacy assets -> sites naming

* various test fixes after rebase

* fixup! chore: update esbuild (#6884)

esbuild 0.24.2 variable naming changes

* fixup! Remove node_compat in Wrangler & Miniflare v4 (#7336)

* feat(wrangler): Drop worker prefix when creating KV namespaces (#7759)

* feat(wrangler): Drop worker prefix when creating KV namespaces

---------

Co-authored-by: Samuel Macleod <[email protected]>

* Include node version in name

* Ignore kv-asset-handler tests on Node 22

* rename tests

* Rename positional `json` args. Fixes #7688

* unescape

* fix tests

* Update .changeset/funny-pets-punch.md

* Add system requirements to the README

* fix formatting

* fix formatting

* Address feedback

* lockfile

* fix test

* Fix changeset format

* Use RC versioning

* feat: graduate `--x-include-runtime` (#8166)

* graduate wrangler type generation to GA

* fixups

* extra changeset

* Fix legacy assets

* Clarify that node support affects Wrangler & Miniflare & kv-asset-handler

* Clarify comment re node 20

* Add more packages

* Remove obsolete tests

* Rename legacyAssets

* more robust isLocal

* fix test snapshot

* Add --legacy-peer-deps so that installing Wrangler v4 doesn't case issues with frameworks that haven't updated their peer dependency for Wrangler v4

* Remove crypto polyfill

* fix kv.local test after rebase

* fix lockfile

* bump rc version

* revert rc versions

---------

Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: Max Rozen <[email protected]>
Co-authored-by: Pedro Leal <[email protected]>
Co-authored-by: emily-shen <[email protected]>
gabivlj pushed a commit that referenced this pull request Mar 13, 2025
* ci: setup next branch with prereleases to next tag

* chore: remove deprecated `getBindingsProxy` (#5005)

* Require Node v18 in Wrangler v4 (#7338)

* Remove node_compat in Wrangler & Miniflare v4 (#7336)

* Remove v2 warning (#7228)

* chore: update esbuild (#6884)

* `--local` by default for `wrangler kv` & `wrangler r2` (#7392)

* deprecate unused D1 commands/options  (#7471)

* chore: remove alpha support from `wrangler d1 migrations apply`

* chore: remove `wrangler d1 backups`

* chore: fixup tests

* chore: fixup tests

* chore: fixup tests

* chore: remove --batch-size

* Remove deprecated commands & config (#7352)

* Remove wrangler version

* Remove generate & strip down init

* Add changesets

* Remove deprecated --format & config

* Add changeset

* remove commands

* Fix tests

* Remove .only()

* Remove legacy assets

* clarify legacy assets -> sites naming

* various test fixes after rebase

* fixup! chore: update esbuild (#6884)

esbuild 0.24.2 variable naming changes

* fixup! Remove node_compat in Wrangler & Miniflare v4 (#7336)

* feat(wrangler): Drop worker prefix when creating KV namespaces (#7759)

* feat(wrangler): Drop worker prefix when creating KV namespaces

---------

Co-authored-by: Samuel Macleod <[email protected]>

* Include node version in name

* Ignore kv-asset-handler tests on Node 22

* rename tests

* Rename positional `json` args. Fixes #7688

* unescape

* fix tests

* Update .changeset/funny-pets-punch.md

* Add system requirements to the README

* fix formatting

* fix formatting

* Address feedback

* lockfile

* fix test

* Fix changeset format

* Use RC versioning

* feat: graduate `--x-include-runtime` (#8166)

* graduate wrangler type generation to GA

* fixups

* extra changeset

* Fix legacy assets

* Clarify that node support affects Wrangler & Miniflare & kv-asset-handler

* Clarify comment re node 20

* Add more packages

* Remove obsolete tests

* Rename legacyAssets

* more robust isLocal

* fix test snapshot

* Add --legacy-peer-deps so that installing Wrangler v4 doesn't case issues with frameworks that haven't updated their peer dependency for Wrangler v4

* Remove crypto polyfill

* fix kv.local test after rebase

* fix lockfile

* bump rc version

* revert rc versions

---------

Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: Max Rozen <[email protected]>
Co-authored-by: Pedro Leal <[email protected]>
Co-authored-by: emily-shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Change that will result in breaking existing behavior caretaking Priority for caretaking

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants