From 47de1affa233713d7f1c8c6a3e55d1a2721d97b9 Mon Sep 17 00:00:00 2001 From: Peter Bacon Darwin Date: Wed, 29 Jan 2025 12:30:00 +0000 Subject: [PATCH] CI: compute the name for artifacts correctly In the `run-c3-e2e` GH Action we compute various things from the inputs. In particular using `experimental` and `quarantine`. But it seems that these are converted to strings rather than booleans, so we cannot simple check the truthy state of `inputs.quarantine`, for example since this might have the value `"false"`, which is truthy. --- .github/actions/run-c3-e2e/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/run-c3-e2e/action.yml b/.github/actions/run-c3-e2e/action.yml index c7e3cca8b32a..86b124c77eef 100644 --- a/.github/actions/run-c3-e2e/action.yml +++ b/.github/actions/run-c3-e2e/action.yml @@ -39,7 +39,7 @@ runs: git config --global user.email wrangler@cloudflare.com git config --global user.name 'Wrangler automated PR updater' - - name: E2E Tests ${{inputs.experimental && '(experimental)' || ''}} + - name: E2E Tests ${{inputs.experimental == 'true' && '(experimental)' || ''}} id: run-e2e shell: bash run: pnpm run test:e2e --filter create-cloudflare @@ -57,8 +57,8 @@ runs: uses: actions/upload-artifact@v4 if: always() with: - name: e2e-logs${{inputs.quarantine && '-quarantine' || ''}}${{inputs.experimental && '-experimental' || ''}}-${{runner.os}}-${{inputs.packageManager}} - path: packages/create-cloudflare/.e2e-logs${{inputs.experimental && '-experimental' || ''}} + name: e2e-logs${{inputs.quarantine == 'true' && '-quarantine' || ''}}${{inputs.experimental == 'true' && '-experimental' || ''}}-${{runner.os}}-${{inputs.packageManager}} + path: packages/create-cloudflare/.e2e-logs${{inputs.experimental == 'true' && '-experimental' || ''}} include-hidden-files: true - name: Fail if errors detected