Suggested determination of OpenCL Target Version (Closes #9) #11
+47
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for setting the OpenCL target version at compile time, addressing issue #9. The implementation sets version 120 (OpenCL 1.2) for macOS systems and version 300 (OpenCL 3.0) for other platforms, matching the minimum OpenCL 1.2 requirement documented in the README.
- Introduces
OPENCL_TARGET_VERSIONvariable that defaults to 300 for non-macOS systems and 120 for macOS - Adds
-DCL_TARGET_OPENCL_VERSIONcompiler flag to PKG_CPPFLAGS using the configured version - Updates configuration summary output to display the selected OpenCL target version with improved formatting alignment
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| configure.ac | Initializes OPENCL_TARGET_VERSION variable, sets platform-specific values (120 for macOS, 300 for others), adds AC_SUBST declaration, and updates summary output with the target version |
| configure | Auto-generated configure script reflecting all changes from configure.ac |
| src/Makevars.in | Adds -DCL_TARGET_OPENCL_VERSION compiler flag to PKG_CPPFLAGS with variable substitution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@eddelbuettel thanks for this! See notes on Element. Let me know if you want me to port that conversation over to issue tickets. Have to go dark for a bit to work on a few items. Will be back around midnight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a simple PR that picks 120 for macOS but otherwise defaults to the current value of 300 for the target version of OpenCL desired at compile time.