Set a default OpenCL version to shut up the library #9
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a default OpenCL version macro to reduce build warnings/noise from the OpenCL library. However, the chosen version (3.0) is higher than the package's documented minimum requirement.
- Sets
CL_TARGET_OPENCL_VERSION=300(OpenCL 3.0) in build configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## It includes GPU backend configuration (OpenCL, CUDA) and other settings | ||
|
|
||
| PKG_CPPFLAGS = -I../inst/include | ||
| PKG_CPPFLAGS = -I../inst/include -DCL_TARGET_OPENCL_VERSION=300 |
There was a problem hiding this comment.
The OpenCL version is set to 300 (OpenCL 3.0), which is higher than the package's documented minimum requirement of OpenCL 1.2 (stated in both DESCRIPTION and README.md). This could break compatibility with systems that have OpenCL versions 1.2-2.2 installed.
The value should be set to 120 to match the minimum requirement:
PKG_CPPFLAGS = -I../inst/include -DCL_TARGET_OPENCL_VERSION=120
Note: In OpenCL versioning, the macro value format is: major * 100 + minor * 10, so 120 = OpenCL 1.2, 300 = OpenCL 3.0.
| PKG_CPPFLAGS = -I../inst/include -DCL_TARGET_OPENCL_VERSION=300 | |
| PKG_CPPFLAGS = -I../inst/include -DCL_TARGET_OPENCL_VERSION=120 |
There was a problem hiding this comment.
@eddelbuettel we need to target v1.2 since the version of OpenCL supported on macOS is 1.2 (November 14, 2012!!!) due to Apple deprecating it in favor of Metal.
https://developer.apple.com/opencl/
If needed, I'm happy to move toward newer headers released by khronos.org/registry/OpenCL/
There was a problem hiding this comment.
How about a peace offering? If we are on that special OS identifying after a long-dead biologist we use 120 else we default to 300? Would that be viable?
This one is more borderline, and @rcurtin already provided sage advice ... but without it the damn build is very very noisy.
I would understand if you said 'cannot pick a version' and close this.