Add 'anaconda' class to document.body in Anaconda mode #22424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
requested changes
Sep 10, 2025
Member
mvollmer
left a comment
mvollmer
left a comment
There was a problem hiding this comment.
Thanks! I'd like to avoid the "random" useEffect and add the class in the "client is initialized" callback.
pkg/storaged/pages.jsx
Outdated
| export const StoragePage = ({ location, plot_state }) => { | ||
| const page = get_page_from_location(location); | ||
|
|
||
| useEffect(() => { |
Member
There was a problem hiding this comment.
Hmm, I think I would prefer this in storaged.jsx, close to the client.init() call.
componentDidMount() {
client.addEventListener("changed", this.on_client_changed);
cockpit.addEventListener("locationchanged", this.on_navigate);
client.init(() => {
if (client.in_anaconda_mode()) {
document.body.classList.add("anaconda");
this.setState({ inited: true });
});
window.setTimeout(() => { if (!this.state.inited) this.setState({ slow_init: true }); }, 1000);
}
Looking at this now, I would also prefer to move the client.init call to the init function in storaged.jsx, but that's something for another day.
Modals are rendered outside the Page component, so they don’t inherit its classes. Adding the 'anaconda' class directly to <body> ensures consistent styling across the UI.
KKoukiou
force-pushed
the
storage-branding-anaconda
branch
from
ab59fd2 to
488ac99
Compare
mvollmer
requested changes
Sep 10, 2025
| client.init(() => { this.setState({ inited: true }) }); | ||
| client.init(() => { | ||
| if (client.in_anaconda_mode()) { | ||
| document.body.classList.add("anaconda"); |
Member
There was a problem hiding this comment.
Shouldn't we keep the changes to pages.jsx from the previous version of this PR?
- <Page id="storage" className={"no-masthead-sidebar" + (client.in_anaconda_mode() ? " anaconda" : "")}>
+ <Page id="storage" className="no-masthead-sidebar">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modals are rendered outside the Page component, so they don’t inherit its classes. Adding the 'anaconda' class directly to ensures consistent styling across the UI.