Skip to content

Commit f48ab34

Browse files
Merge pull request #342 from shyim/patch-1
fix: php 8.4 deprecation about implicit null arguments
2 parents 98d5b56 + 38e4d18 commit f48ab34

File tree

4 files changed

+5
-54
lines changed

4 files changed

+5
-54
lines changed

.github/workflows/unit.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ jobs:
2727
- php: "8.3"
2828
mode: experimental
2929
os: ubuntu-20.04
30+
- php: "8.4"
31+
mode: experimental
32+
os: ubuntu-20.04
3033
fail-fast: false
3134

3235
runs-on: "${{ matrix.os }}"

.travis.yml

Lines changed: 0 additions & 52 deletions
This file was deleted.

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
}
2020
],
2121
"require": {
22-
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
22+
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
2323
"ext-mbstring": "*"
2424
},
2525
"conflict": {

src/Slugify.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class Slugify implements SlugifyInterface
8080
* @param array $options
8181
* @param RuleProviderInterface $provider
8282
*/
83-
public function __construct(array $options = [], RuleProviderInterface $provider = null)
83+
public function __construct(array $options = [], ?RuleProviderInterface $provider = null)
8484
{
8585
$this->options = array_merge($this->options, $options);
8686
$this->provider = $provider ? $provider : new DefaultRuleProvider();

0 commit comments

Comments
 (0)