fix: remove ValidatedString and TestrunOrSkipped

I previously added these because we were having issues storing very long test
names and I wanted to "validate" the data that came in to make sure that we're
not including random strings for test names that might include source code. The
main problem was that we weren't able to index that data in timescale and that
was causing issues. I've since removed those indexes and if we have to index
on names we'll have to use full text indexes next time, but for now we don't
need this anymore. In the future, we'll likely have to add some mechanism for
users to "ignore" irrelevant tests in the UI, or filter the names of tests. In
any case, the scope of this library is to simply parse a JUnit XML file, so we
should stick to that here, and avoid trying to do more.

Author: joseph-sentry

benches/binary.rs

@@ -6,7 +6,7 @@ use rand::rngs::SmallRng;
 use rand::seq::SliceRandom as _;
 use rand::{Rng, SeedableRng};
 use test_results_parser::binary::*;
-use test_results_parser::{Outcome, PropertiesValue, Testrun, ValidatedString};
+use test_results_parser::{Outcome, PropertiesValue, Testrun};
 
 criterion_group!(benches, binary);
 criterion_main!(benches);
@@ -175,15 +175,15 @@ fn create_random_testcases(
                     let name = Alphanumeric.sample_string(rng, name_len);
 
                     Testrun {
-                        name: name.try_into().unwrap(),
-                        classname: ValidatedString::default(),
+                        name: name,
+                        classname: String::new(),
                         duration: Some(1.0),
                         outcome: Outcome::Pass,
-                        testsuite: ValidatedString::default(),
+                        testsuite: String::new(),
                         failure_message: None,
                         filename: None,
                         build_url: None,
-                        computed_name: ValidatedString::default(),
+                        computed_name: String::new(),
                         properties: PropertiesValue(None),
                     }
                 })

src/binary/mod.rs

@@ -18,24 +18,21 @@ mod tests {
     use raw::CommitHash;
     use timestamps::DAY;
 
-    use crate::{
-        testrun::{Outcome, PropertiesValue, Testrun},
-        validated_string::ValidatedString,
-    };
+    use crate::testrun::{Outcome, PropertiesValue, Testrun};
 
     use super::*;
 
     fn test() -> Testrun {
         Testrun {
-            name: "abc".try_into().unwrap(),
-            classname: ValidatedString::default(),
+            name: "abc".to_string(),
+            classname: String::new(),
             duration: Some(1.0),
             outcome: Outcome::Pass,
-            testsuite: ValidatedString::default(),
+            testsuite: String::new(),
             failure_message: None,
             filename: None,
             build_url: None,
-            computed_name: ValidatedString::default(),
+            computed_name: String::new(),
             properties: PropertiesValue(None),
         }
     }
@@ -64,7 +61,7 @@ mod tests {
         test.duration = Some(2.0);
         session.insert(&test);
 
-        test.name = "def".try_into().unwrap();
+        test.name = "def".into();
         test.outcome = Outcome::Skip;
         test.duration = Some(0.0);
         session.insert(&test);
@@ -98,7 +95,7 @@ mod tests {
         let mut session = writer.start_session(0, CommitHash::default(), &[]);
 
         session.insert(&test);
-        test.testsuite = "some testsuite".try_into().unwrap();
+        test.testsuite = "some testsuite".into();
         session.insert(&test);
 
         let mut buf = vec![];