fix: make retriable uploads retriable even if no error

Author: thomasrockhu-codecov

libs/shared/shared/django_apps/upload_breadcrumbs/admin.py

@@ -560,9 +560,6 @@ def get_urls(self):
     @admin.display(description="Actions", ordering=None)
     def resend_upload_button(self, obj: UploadBreadcrumb) -> str:
         """Display resend button in the list view for failed uploads."""
-        if not self._is_failed_upload(obj):
-            return "-"
-
         resend_url = reverse(
             "admin:upload_breadcrumbs_uploadbreadcrumb_resend_upload", args=[obj.id]
         )
@@ -577,24 +574,16 @@ def resend_upload_action(self, obj: UploadBreadcrumb) -> str:
         if not obj.pk:  # New object
             return "-"
 
-        html_parts = []
-
-        if self._is_failed_upload(obj):
-            resend_url = reverse(
-                "admin:upload_breadcrumbs_uploadbreadcrumb_resend_upload", args=[obj.id]
-            )
-            html_parts.append(
-                f'<a class="button default" href="{resend_url}" '
-                f"onclick=\"return confirm('Are you sure you want to resend this upload for commit {obj.commit_sha[:7]}?')\">🔄 Resend Upload</a>"
-                "<br><br>"
-                "<div><strong>⚠️ Note:</strong> This will create a new upload task for the same commit and repository. "
-                "The original upload data may no longer be available in storage.</div>"
-            )
-        else:
-            html_parts.append(
-                "<div>✅ This upload does not appear to have failed. Resend option is not available.</div>"
-            )
-
+        resend_url = reverse(
+            "admin:upload_breadcrumbs_uploadbreadcrumb_resend_upload", args=[obj.id]
+        )
+        html_parts = [
+            f'<a class="button default" href="{resend_url}" '
+            f"onclick=\"return confirm('Are you sure you want to resend this upload for commit {obj.commit_sha[:7]}?')\">🔄 Resend Upload</a>"
+            "<br><br>"
+            "<div><strong>⚠️ Note:</strong> This will create a new upload task for the same commit and repository. "
+            "The original upload data may no longer be available in storage.</div>"
+        ]
         return format_html("".join(html_parts))
 
     def _is_failed_upload(self, obj: UploadBreadcrumb) -> bool:
@@ -624,10 +613,6 @@ def resend_upload_view(self, request, object_id):
                 messages.error(request, "Upload breadcrumb not found.")
                 return redirect("admin:upload_breadcrumbs_uploadbreadcrumb_changelist")
 
-            if not self._is_failed_upload(breadcrumb):
-                messages.error(request, "This upload does not appear to have failed.")
-                return redirect("admin:upload_breadcrumbs_uploadbreadcrumb_changelist")
-
             success, error_message = self._resend_upload(breadcrumb, request.user)
 
             if success: