Skip to content

Commit 401d1b0

Browse files
committed
Fix: Wrongly generated AM wave
The AM wave gen calculation was wrong resulting is wrong frequency components, which can be seen in the FFT and also just at looking at the shape of the wave. Multiple changes were done surrounding this fix. * tools/DacValues * Fix: AM wave gen calculation * Older/wrong AM wave data replaced with newer ones. Some deleted. * Documentation update to show the new calculation and other general information added. * Firmware * Now using the corrected values to generate AM. * AM wave now 2250 sample points at 1.5x frequency. This change is not part of the fix, but done to make `fc/fm` lower making it easier to see the AM bands in frequency domain * Screenshots updated * Unittest * Fix: AM test break due to the higher frequency of AM wave (2nd change above)
1 parent 9fbdf2f commit 401d1b0

File tree

12 files changed

+7510
-8325
lines changed

12 files changed

+7510
-8325
lines changed

docs/images/am_wave.png

-6.18 KB
Loading

docs/images/am_wave_fft.png

22.1 KB
Loading

src/fw/tests.c

Lines changed: 83 additions & 240 deletions
Large diffs are not rendered by default.

src/unittests/feature_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ YT_TEST (am, am_wave_normal)
275275

276276
// As AM wave slowly increases in amplitde we expect more than 10 carrier waves reaching rail to
277277
// rail values.
278-
YT_IN_SEQUENCE (10)
278+
YT_IN_SEQUENCE (5)
279279
{
280280
// 2. Then it must reach the maximum value
281281
YT_MUST_CALL_IN_ORDER (HAL_IO_OUT_WRITE, YT_V (ANALOG_OUTPUT_GPIO),

0 commit comments

Comments
 (0)