Address code review feedback

- Changed BuildAction from Content to None for MSBuild task assemblies
- Simplified property assignment using MSBuild ValueOrDefault function
- Removed redundant CopyToOutputDirectory setting from test scenario
- Added README to test-scenario explaining the feature

Co-authored-by: Soar360 <[email protected]>

Author: Copilot

LuYao.ResourcePacker.MSBuild/LuYao.ResourcePacker.MSBuild.csproj

@@ -30,17 +30,17 @@
       <_PackageFiles Include="$(OutputPath)LuYao.ResourcePacker.MSBuild.dll">
         <PackagePath>tasks/$(TargetFramework)</PackagePath>
         <Visible>false</Visible>
-        <BuildAction>Content</BuildAction>
+        <BuildAction>None</BuildAction>
       </_PackageFiles>
       <_PackageFiles Include="$(OutputPath)LuYao.ResourcePacker.dll">
         <PackagePath>tasks/$(TargetFramework)</PackagePath>
         <Visible>false</Visible>
-        <BuildAction>Content</BuildAction>
+        <BuildAction>None</BuildAction>
       </_PackageFiles>
       <_PackageFiles Include="$(OutputPath)LuYao.ResourcePacker.SourceGenerator.dll">
         <PackagePath>analyzers/dotnet/cs</PackagePath>
         <Visible>false</Visible>
-        <BuildAction>Content</BuildAction>
+        <BuildAction>None</BuildAction>
       </_PackageFiles>
     </ItemGroup>
   </Target>

LuYao.ResourcePacker.MSBuild/build/LuYao.ResourcePacker.MSBuild.targets

@@ -6,8 +6,7 @@
   <Target Name="PackResources" BeforeTargets="AssignTargetPaths" Condition="'$(ResourcePackerEnabled)' == 'true'">
     <PropertyGroup>
       <!-- Use MSBuildProjectName if AssemblyName is not set -->
-      <_AssemblyNameForPacker Condition="'$(AssemblyName)' != ''">$(AssemblyName)</_AssemblyNameForPacker>
-      <_AssemblyNameForPacker Condition="'$(AssemblyName)' == ''">$(MSBuildProjectName)</_AssemblyNameForPacker>
+      <_AssemblyNameForPacker>$([MSBuild]::ValueOrDefault('$(AssemblyName)', '$(MSBuildProjectName)'))</_AssemblyNameForPacker>
       <ResourcePackerOutputFileName Condition="'$(ResourcePackerOutputFileName)' == ''">$(_AssemblyNameForPacker).dat</ResourcePackerOutputFileName>
     </PropertyGroup>
     <ResourcePackerTask

test-scenario/LibA/LibA.csproj

@@ -11,7 +11,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Include="Resources\**\*.res.*" CopyToOutputDirectory="Never" />
+    <None Include="Resources\**\*.res.*" />
   </ItemGroup>
 
 </Project>

test-scenario/README.md

@@ -0,0 +1,49 @@
+# Test Scenario: Non-Transitive Dependency
+
+This test scenario demonstrates that the MSBuild and Source Generator components of LuYao.ResourcePacker.MSBuild are NOT transitively referenced.
+
+## Project Structure
+
+```
+LibA (references LuYao.ResourcePacker.MSBuild via NuGet)
+  └── Contains test.res.txt resource file
+  └── Generates LibA.dat during build
+
+LibB (references LibA)
+  └── Does NOT get MSBuild/SG functionality
+  └── Does receive LibA.dat in output
+
+App2 (references LibB)
+  └── Does NOT get MSBuild/SG functionality
+  └── Does receive LibA.dat in output
+```
+
+## Expected Behavior
+
+1. **LibA**: MSBuild targets execute, generates `LibA.dat`
+2. **LibB**: MSBuild targets do NOT execute (no transitive import), but `LibA.dat` is copied to output
+3. **App2**: MSBuild targets do NOT execute (no transitive import), but `LibA.dat` is copied to output
+
+## Testing
+
+```bash
+# Build the entire chain
+cd test-scenario
+dotnet build App2/App2.csproj
+
+# Verify LibA has LibA.dat
+ls LibA/bin/Debug/net8.0/LibA.dat
+
+# Verify LibB has LibA.dat but NOT LibB.dat
+ls LibB/bin/Debug/net8.0/LibA.dat
+ls LibB/bin/Debug/net8.0/LibB.dat  # Should not exist
+
+# Verify App2 has LibA.dat
+ls App2/bin/Debug/net8.0/LibA.dat
+```
+
+## Key Points
+
+- The `LuYao.ResourcePacker.MSBuild` package only imports build assets for **direct** references
+- The runtime dependency (`LuYao.ResourcePacker`) **IS** transitively passed
+- Generated `.dat` files are copied to all consuming projects via the `CopyToOutputDirectory` setting