create_host_path must not be omitted when set to false

Signed-off-by: Nicolas De Loof <[email protected]>

Author: ndeloof

types/types.go

@@ -564,12 +564,20 @@ const (
 type ServiceVolumeBind struct {
 	SELinux        string `yaml:"selinux,omitempty" json:"selinux,omitempty"`
 	Propagation    string `yaml:"propagation,omitempty" json:"propagation,omitempty"`
-	CreateHostPath bool   `yaml:"create_host_path,omitempty" json:"create_host_path,omitempty"`
+	CreateHostPath OptOut `yaml:"create_host_path,omitempty" json:"create_host_path,omitempty"`
 	Recursive      string `yaml:"recursive,omitempty" json:"recursive,omitempty"`
 
 	Extensions Extensions `yaml:"#extensions,inline,omitempty" json:"-"`
 }
 
+// OptOut is a boolean which default value is 'true'
+type OptOut bool
+
+func (o OptOut) IsZero() bool {
+	// Attribute can be omitted if value is true
+	return bool(o)
+}
+
 // SELinux represents the SELinux re-labeling options.
 const (
 	// SELinuxShared option indicates that the bind mount content is shared among multiple containers

types/types_test.go

@@ -380,3 +380,37 @@ func TestMappingValues(t *testing.T) {
 	})
 	assert.DeepEqual(t, mapping.Values(), values)
 }
+
+func TestMarhsall(t *testing.T) {
+	p := Project{
+		Services: Services{
+			"test": ServiceConfig{
+				Volumes: []ServiceVolumeConfig{
+					{
+						Type: "bind",
+						Bind: &ServiceVolumeBind{
+							CreateHostPath: true, // default
+						},
+					},
+					{
+						Type: "bind",
+						Bind: &ServiceVolumeBind{
+							CreateHostPath: false,
+						},
+					},
+				},
+			},
+		},
+	}
+	marshalYAML, err := p.MarshalYAML()
+	assert.NilError(t, err)
+	assert.Equal(t, string(marshalYAML), `services:
+  test:
+    volumes:
+      - type: bind
+        bind: {}
+      - type: bind
+        bind:
+          create_host_path: false
+`)
+}