[package] gettext/0.21: Errors with ISO C 23 compilers

[AnatoliiShablov]

Description

Unable to compile gettext/0.21. It's not the latest version of gettext in conan-center, but used as build requirement in latest ffmpeg/8.0 (ffmpeg/8.0 -> pulseaudio/14.2 -> gettext/0.21). This bug was resolved in gettext/0.22, but can be cherry-picked from this autotools-mirror/gettext@cb2c148

Package and Environment Details

• Package Name/Version: gettext/0.21
• Operating System+version: OpenSUSE Tumbleweed
• Compiler+version: GCC 15.2
• Conan version: conan 2.22.2
• Python version: Python 3.13.9

Conan profile

Host profile:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=15
os=Linux

Build profile:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=15
os=Linux

Steps to reproduce

conan install --requires=gettext/0.21 --build=missing --settings=build_type=Release --settings=compiler.cppstd=20

Logs

Click to expand log

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl -I.. -DLOCALEDIR=\"//res/locale\" -DLOCALE_ALIAS_PATH=\"\" -DLIBDIR=\"//lib\" -DBUILDING_LIBINTL -DBUILDING_DLL -DIN_LIBINTL -DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR=\"//lib\" -DNO_XMALLOC -Dset_relocation_prefix=libintl_set_relocation_prefix -Drelocate=libintl_relocate -Drelocate2=libintl_relocate2 -DDEPENDS_ON_LIBICONV=1 -DNDEBUG -I/home/someusername/.conan2/p/b/libicd3370ad59009a/p/include -fvisibility=hidden -m64 -O3 -c /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/ngettext.c -o ngettext.o
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcngettext.c:21:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl -I.. -DLOCALEDIR=\"//res/locale\" -DLOCALE_ALIAS_PATH=\"\" -DLIBDIR=\"//lib\" -DBUILDING_LIBINTL -DBUILDING_DLL -DIN_LIBINTL -DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR=\"//lib\" -DNO_XMALLOC -Dset_relocation_prefix=libintl_set_relocation_prefix -Drelocate=libintl_relocate -Drelocate2=libintl_relocate2 -DDEPENDS_ON_LIBICONV=1 -DNDEBUG -I/home/someusername/.conan2/p/b/libicd3370ad59009a/p/include -fvisibility=hidden -m64 -O3 -c /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/localename.c -o localename.o
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/localealias.c:61:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/textdomain.c:24:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dngettext.c:21:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c:92:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c: At top level:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c:147:7: error: conflicting types for ‘getcwd’; have ‘char *(void)’
  147 | char *getcwd ();
      |       ^~~~~~
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c:65:
/usr/include/unistd.h:531:14: note: previous declaration of ‘getcwd’ with type ‘char *(char *, size_t)’ {aka ‘char *(char *, long unsigned int)’}
  531 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur;
      |              ^~~~~~
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c: In function ‘libintl_dcigettext’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c:700:21: error: too many arguments to function ‘getcwd’; expected 0, have 2
  700 |               ret = getcwd (resolved_dirname, path_max);
      |                     ^~~~~~  ~~~~~~~~~~~~~~~~
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/dcigettext.c:147:7: note: declared here
  147 | char *getcwd ();
      |       ^~~~~~
make[5]: *** [Makefile:2008: dcigettext.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/ngettext.c:28:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl -I.. -DLOCALEDIR=\"//res/locale\" -DLOCALE_ALIAS_PATH=\"\" -DLIBDIR=\"//lib\" -DBUILDING_LIBINTL -DBUILDING_DLL -DIN_LIBINTL -DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR=\"//lib\" -DNO_XMALLOC -Dset_relocation_prefix=libintl_set_relocation_prefix -Drelocate=libintl_relocate -Drelocate2=libintl_relocate2 -DDEPENDS_ON_LIBICONV=1 -DNDEBUG -I/home/someusername/.conan2/p/b/libicd3370ad59009a/p/include -fvisibility=hidden -m64 -O3 -c /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/localename-table.c -o localename-table.o
In file included from /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/localename.c:25:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h: In function ‘SWAP’:
/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/src/gettext-runtime/intl/gettextP.h:119:1: warning: old-style function definition [-Wold-style-definition]
  119 | SWAP (i)
      | ^~~~
make[5]: Leaving directory '/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/build-release/gettext-runtime/intl'
make[4]: *** [Makefile:1594: all] Error 2
make[4]: Leaving directory '/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/build-release/gettext-runtime/intl'
make[3]: *** [Makefile:1467: all-recursive] Error 1
make[3]: Leaving directory '/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/build-release/gettext-runtime'
make[2]: *** [Makefile:1374: all] Error 2
make[2]: Leaving directory '/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/build-release/gettext-runtime'
make[1]: *** [Makefile:403: all-recursive] Error 1
make[1]: Leaving directory '/home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/build-release'
make: *** [Makefile:359: all] Error 2

gettext/0.21: ERROR: 
Package 'd5498a12e03ed8a3e29647fa4004ec3512635fbc' build failed
gettext/0.21: WARN: Build folder /home/someusername/.conan2/p/b/gettea54d2d8953bc0/b/build-release
ERROR: gettext/0.21: Error in build() method, line 127
        autotools.make()
        ConanException: Error 2 while executing

[jcar87]

Thanks for reporting this @AnatoliiShablov

We can start moving the versions forward - does #28926 fix this issue when building ffmpeg for you?

[AnatoliiShablov]

I'm checking, but seems that we need to update mpg123 dep too
pulseaudio/14.2 (also pulseaudio/17.0) -> libsndfile/1.2.2 -> mpg123/1.31.2

/home/someuser/.conan2/p/b/mpg12a89b3fe9fea70/b/src/src/streamdump.c: In function ‘dump_setup’:
/home/someuser/.conan2/p/b/mpg12a89b3fe9fea70/b/src/src/streamdump.c:691:17: error: too many arguments to function ‘dump_close’; expected 0, have 1
  691 |                 dump_close(sd);
      |                 ^~~~~~~~~~ ~~
In file included from /home/someuser/.conan2/p/b/mpg12a89b3fe9fea70/b/src/src/streamdump.c:16:
/home/someuser/.conan2/p/b/mpg12a89b3fe9fea70/b/src/src/streamdump.h:53:6: note: declared here
   53 | void dump_close();
      |      ^~~~~~~~~~

And also patch that is already in 1.33
Here is merge to 1.32.4 (libsdl-org/mpg123@a06847c)
And this is specific commit (found in anonther repo) merge contains this changes
madebr/mpg123@842f908

[AnatoliiShablov]

Yep, when i added self.requires("mpg123/1.33.0", override=True) to my recipe build succeed. So i can create similar patch probably with range to mpg123