subscription: Added context cancellation and sync to subscription set #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotSoFancyName
changed the title
Luap99
reviewed
Oct 30, 2025
NotSoFancyName
force-pushed
the
subscription-set-fix
branch
from
cbd00ca to
8e6a091
Compare
Contributor
Author
|
Valid points |
Luap99
reviewed
Oct 30, 2025
NotSoFancyName
force-pushed
the
subscription-set-fix
branch
2 times, most recently
from
8b68866 to
4f5dc49
Compare
Fixes: coreos#474 Signed-off-by: Volodymyr Pankin <[email protected]>
NotSoFancyName
force-pushed
the
subscription-set-fix
branch
from
4f5dc49 to
04ca6fb
Compare
Contributor
Author
|
@kolyshkin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to cancel unit subsciptions with context which eliminates existing goroutine leak
Added synchronization primitive for
SubscriptioSet, now it should it be possible to add new units to the set after executingSubscribeContextFixes: #474