[5.x]: EVENT_AFTER_ORDER_PAID can be re-run

[philipboomy]

What happened?

Description

I am not sure if it's a bug but I thought I would report it just in case.

If I partially refund an order and then adjust the order amount by for example adding a discount adjuster to match the refunded the amount so the order goes into paid status again then this event EVENT_AFTER_ORDER_PAID is triggered again. Is that on purpose? I believe it only happens due to Stripe webhooks as I cannot reproduce locally nor on staging where neither has Stripe webhooks running.

Steps to reproduce

1. Partial refund a paid order
2. Add a discount adjuster for the refunded amount so paid status is now "paid" again instead of partial paid.
3. See that the event EVENT_AFTER_ORDER_PAID is triggered again after the Stripe webhook has been received

Expected behavior

That EVENT_AFTER_ORDER_PAID is only run once as the order was only paid once.

Actual behavior

EVENT_AFTER_ORDER_PAID is triggered again

Craft CMS version

5.8.17

Craft Commerce version

5.4.6

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear]

COM-486

[nfourtythree]

Hi @philipboomy

Thank you for your message. There are some similarities with the discussion resurrected on this issue: #1026

This is something we will be investigating to see what is happening in the various different scenarios.

One thing I would mention about the process you described is related to your use of a discount adjuster. If I understand correctly you are using a custom one to add a positive value? Although this in theory is technically possible we would recommend against this.

If you are trying to balance the short fall in the paid amount, we would suggest adding the manual payment gateway (enabled only for store managers) so they can add a balancing transaction amount. Also in the interim you could do this before you do the refund, which would then actually prevent the order ever dropping out of a paid status. Obviously not the most ideal way but at least a stop gap while we provide further information or potential changes on this issue.

Thanks!

[philipboomy]

@nfourtythree Thank you for your very quick reply.

In most cases I am using the discount adjuster on the order to add a negative amount to apply a coupon code after payment. Some customers forget to add the coupon so we add it manually after payment and then refunding the amount. We need to use the discount adjuster so we can keep track of the amounts for book keeping purposes. When we run our reports we can then sum up all discounts (both manually applied like above or automated using a coupon frontend).

I will try with the adjuster before refunding to see if I can I use that as a work around.

Thanks.

[nfourtythree]

Hi

As a way of an update. In the upcoming Commerce 5.5 release we are adding a new property to orders.

This new property is dateFirstPaid this tracks the date the order was first fully paid and will never change from that date. This gives further information to be able to be able to base any project logic from.

Thanks!