Skip to content

Commit 3f5c519

Browse files
authored
fix: use correct property for group accesstoken name (#240)
Signed-off-by: ralf.weber <[email protected]>
1 parent baf29b5 commit 3f5c519

File tree

8 files changed

+12
-4
lines changed

8 files changed

+12
-4
lines changed

pkg/cluster/clients/groups/zz_accesstoken.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cluster/clients/projects/zz_accesstoken.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cluster/controller/groups/accesstokens/zz_controller_test.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cluster/controller/projects/accesstokens/zz_controller_test.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/namespaced/clients/groups/accesstoken.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func NewAccessTokenClient(cfg common.Config) AccessTokenClient {
4949
// GenerateCreateGroupAccessTokenOptions generates project creation options
5050
func GenerateCreateGroupAccessTokenOptions(name string, p *v1alpha1.AccessTokenParameters) *gitlab.CreateGroupAccessTokenOptions {
5151
accesstoken := &gitlab.CreateGroupAccessTokenOptions{
52-
Name: &name,
52+
Name: &p.Name,
5353
Scopes: &p.Scopes,
5454
}
5555

pkg/namespaced/clients/projects/accesstoken.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func NewAccessTokenClient(cfg common.Config) AccessTokenClient {
4949
// GenerateCreateProjectAccessTokenOptions generates project creation options
5050
func GenerateCreateProjectAccessTokenOptions(name string, p *v1alpha1.AccessTokenParameters) *gitlab.CreateProjectAccessTokenOptions {
5151
accesstoken := &gitlab.CreateProjectAccessTokenOptions{
52-
Name: &name,
52+
Name: &p.Name,
5353
Scopes: &p.Scopes,
5454
}
5555

pkg/namespaced/controller/groups/accesstokens/controller_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,7 @@ func TestCreate(t *testing.T) {
476476
cr: accessToken(
477477
withSpec(v1alpha1.AccessTokenParameters{
478478
GroupID: &id,
479+
Name: "Access Token Name",
479480
}),
480481
withAnnotations(extNameAnnotation),
481482
),
@@ -484,6 +485,7 @@ func TestCreate(t *testing.T) {
484485
cr: accessToken(
485486
withSpec(v1alpha1.AccessTokenParameters{
486487
GroupID: &id,
488+
Name: "Access Token Name",
487489
}),
488490
withExternalName(sAccessTokenID),
489491
),

pkg/namespaced/controller/projects/accesstokens/controller_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -480,6 +480,7 @@ func TestCreate(t *testing.T) {
480480
cr: accessToken(
481481
withSpec(v1alpha1.AccessTokenParameters{
482482
ProjectID: &projectID,
483+
Name: "Access Token Name",
483484
}),
484485
withAnnotations(extNameAnnotation),
485486
),
@@ -488,6 +489,7 @@ func TestCreate(t *testing.T) {
488489
cr: accessToken(
489490
withSpec(v1alpha1.AccessTokenParameters{
490491
ProjectID: &projectID,
492+
Name: "Access Token Name",
491493
}),
492494
withExternalName(sAccessTokenID),
493495
),

0 commit comments

Comments
 (0)