Skip to content

fix: User key replaced by Team key in GroupsTeam structure #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: User key replaced by Team key in GroupsTeam structure #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crowdin/model/teams.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,5 +224,5 @@ type TeamsGetResponse struct {
// GroupsTeam represents a group team.
type GroupsTeam struct {
ID int `json:"id"`
User *Team `json:"user"`
Team *Team `json:"team"`
}
50 changes: 25 additions & 25 deletions crowdin/teams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,8 +696,8 @@ func TestGroupsTeamsService_List(t *testing.T) {
"data": [
{
"data": {
"id": 27,
"user": {
"id": 27,
"team": {
"id": 2,
"name": "Translators Team",
"totalMembers": 8,
Expand Down Expand Up @@ -725,7 +725,7 @@ func TestGroupsTeamsService_List(t *testing.T) {
{
Data: &model.GroupsTeam{
ID: 27,
User: &model.Team{
Team: &model.Team{
ID: 2,
Name: "Translators Team",
TotalMembers: 8,
Expand All @@ -737,7 +737,7 @@ func TestGroupsTeamsService_List(t *testing.T) {
},
}

if teams[0].User.Name != want[0].Data.User.Name {
if teams[0].Team.Name != want[0].Data.Team.Name {
t.Errorf("Managers.List returned ID %v, want %v", teams[0].ID, want[0].Data.ID)
}

Expand Down Expand Up @@ -770,13 +770,13 @@ func TestGroupTeamsService_Get(t *testing.T) {
fmt.Fprint(w, `{
"data": {
"id": 27,
"user": {
"id": 2,
"name": "Translators Team",
"totalMembers": 8,
"webUrl": "https://example.crowdin.com/u/teams/1",
"createdAt": "2019-09-23T09:04:29+00:00",
"updatedAt": "2019-09-23T09:04:29+00:00"
"team": {
"id": 2,
"name": "Translators Team",
"totalMembers": 8,
"webUrl": "https://example.crowdin.com/u/teams/1",
"createdAt": "2019-09-23T09:04:29+00:00",
"updatedAt": "2019-09-23T09:04:29+00:00"
}
}
}`)
Expand All @@ -790,7 +790,7 @@ func TestGroupTeamsService_Get(t *testing.T) {
want := &model.TeamsGetResponse{
Data: &model.GroupsTeam{
ID: 18,
User: &model.Team{
Team: &model.Team{
ID: 2,
Name: "Translators Team",
TotalMembers: 8,
Expand All @@ -801,7 +801,7 @@ func TestGroupTeamsService_Get(t *testing.T) {
},
}

if teams.User.ID != want.Data.User.ID {
if teams.Team.ID != want.Data.Team.ID {
t.Errorf("Managers.Get returned %+v, want %+v", teams, want)
}
}
Expand All @@ -817,18 +817,18 @@ func TestGroupTeamsService_Edit(t *testing.T) {
fmt.Fprint(w, `{
"data": [
{
"data": {
"id": 2,
"user": {
"id": 18,
"name": "Translators Team",
"totalMembers": 8,
"webUrl": "https://example.crowdin.com/u/teams/1",
"createdAt": "2019-09-23T09:04:29+00:00",
"updatedAt": "2019-09-23T09:04:29+00:00"
"data": {
"id": 2,
"team": {
"id": 18,
"name": "Translators Team",
"totalMembers": 8,
"webUrl": "https://example.crowdin.com/u/teams/1",
"createdAt": "2019-09-23T09:04:29+00:00",
"updatedAt": "2019-09-23T09:04:29+00:00"
}
}
}
}
]
}`)
})
Expand All @@ -849,8 +849,8 @@ func TestGroupTeamsService_Edit(t *testing.T) {

want := 18

if teams[0].User.ID != want {
t.Errorf("Managers.Edit returned %+v, want %+v", teams[0].User.ID, want)
if teams[0].Team.ID != want {
t.Errorf("Managers.Edit returned %+v, want %+v", teams[0].Team.ID, want)
}
}

Expand Down
Loading