feat: Support new 'Remove String Approvals' API endpoint (#95)

* refactor: delete_string_translations to use the SendRequest
* feat: support new 'Remove String Approvals' API endpoint

Author: IgorFroehner

lib/crowdin-api/api_resources/string_translations.rb

@@ -51,6 +51,18 @@ def remove_approval(approval_id = nil, project_id = config.project_id)
         Web::SendRequest.new(request).perform
       end
 
+      def remove_string_approvals(query = {}, project_id = config.project_id)
+        project_id || raise_project_id_is_required_error
+
+        request = Web::Request.new(
+          connection,
+          :delete,
+          "#{config.target_api_url}/projects/#{project_id}/approvals",
+          { params: query }
+        )
+        Web::SendRequest.new(request).perform
+      end
+
       def list_language_translations(language_id = nil, query = {}, project_id = config.project_id)
         language_id || raise_parameter_is_required_error(:language_id)
         project_id  || raise_project_id_is_required_error
@@ -91,17 +103,13 @@ def add_translation(query = {}, project_id = config.project_id)
       def delete_string_translations(query = {}, project_id = config.project_id)
         project_id || raise_project_id_is_required_error
 
-        response = ::RestClient::Request.execute(
-          {
-            method: :delete,
-            url: config.base_url + config.target_api_url + "/projects/#{project_id}/translations",
-            payload: query.to_json
-          }.merge(@options)
+        request = Web::Request.new(
+          connection,
+          :delete,
+          "#{config.target_api_url}/projects/#{project_id}/translations",
+          { params: query }
         )
-
-        response.body.empty? ? response.code : JSON.parse(response.body)
-      rescue StandardError => e
-        e.message
+        Web::SendRequest.new(request).perform
       end
 
       def get_translation(translation_id = nil, query = {}, project_id = config.project_id)

lib/crowdin-api/core/request.rb

@@ -26,7 +26,7 @@ def delete?
       end
 
       def delete
-        connection.delete
+        connection.delete(prepare_payload(payload[:params]))
       end
 
       def process_with_body
@@ -60,7 +60,7 @@ def build_payload(payload)
         def prepare_payload(params)
           return params if params.is_a?(File)
 
-          get? ? { params: fetch_cleared_params(params) } : fetch_cleared_params(params).to_json
+          get? || delete? ? { params: fetch_cleared_params(params) } : fetch_cleared_params(params).to_json
         end
 
         def fetch_cleared_params(params)

spec/api_resources/string_translations_spec.rb

@@ -38,6 +38,14 @@
       end
     end
 
+    describe '#remove_string_approvals' do
+      it 'when request are valid', :default do
+        stub_request(:delete, "https://api.crowdin.com/#{target_api_url}/projects/#{project_id}/approvals")
+        remove_string_approvals = @crowdin.remove_string_approvals({}, project_id)
+        expect(remove_string_approvals).to eq(200)
+      end
+    end
+
     describe '#list_language_translations' do
       let(:language_id) { 1 }