Skip to content

Conversation

@h0ethan04
Copy link
Collaborator

Description

Screenshots/Media

Issues

Closes #

@h0ethan04 h0ethan04 requested review from Copilot and stevem-zhou June 10, 2025 20:20
@h0ethan04 h0ethan04 self-assigned this Jun 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges changes from the dev branch into the toast branch and updates a wide range of components and configuration files. Key changes include UI and styling adjustments in multiple modals and view components, refactoring and cleanup in teacher-related components, and modifications to routing and workflow configuration.

Reviewed Changes

Copilot reviewed 141 out of 141 changed files in this pull request and generated no comments.

Show a summary per file
File Description
client/src/components/bookings/teacherView/qrcode/ClassCheckInHandler.jsx Reordered imports and slightly reformatted localStorage usage.
client/src/components/bookings/teacherView/qrcode/CheckInHandler.jsx Removed obsolete console logs and commented code.
client/src/components/bookings/teacherView/TeacherEventViewModal.jsx Updated modal layout and added support for tags and new positioning props.
client/src/components/bookings/TeacherEditModal.jsx Refactored tag handling and instructor data fetching; improved asynchronous deletion logic.
Other files (e.g., TeacherViewModal.jsx, ProtectedRoute.tsx, CatchAll.tsx, Workflows) Minor UI tweaks, routing changes, import reordering, and CI workflow branch updates.
Comments suppressed due to low confidence (2)

client/src/components/bookings/TeacherEditModal.jsx:210

  • Consider using Promise.all to await all asynchronous deletion calls when removing class tags. This change will ensure that all deletion operations complete (or fail) before proceeding, improving error handling and synchronization.
tags.map(async (tag) => { await backend.delete(`/class-tags/${classData.id}/${tag.id}`).catch((err) => { console.error(err); }); });

.github/workflows/run-checks.yml:28

  • Reconsider removing the '--frozen-lockfile' flag from the dependency installation command. Retaining it can help ensure reproducible builds by strictly enforcing resolved dependency versions.
node_modules && yarn install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants