You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+12-6Lines changed: 12 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,31 +4,37 @@ For general guidance on contributing to Cucumber, see https://github.com/cucumbe
4
4
5
5
## Adding or changing query methods
6
6
7
-
This is a polyglot repo with several languages adhering to a common suite of acceptance tests. A change should be made consistently across all languages. Currently, the list is:
7
+
This is a polyglot repo with several languages adhering to a common suite of
8
+
acceptance tests. A change should be made consistently across all languages.
9
+
Currently, the list is:
8
10
9
11
- Java (reference)
10
12
- JavaScript
11
13
- C# (.NET)
12
14
13
-
Java is the reference implementation in the sense that it is responsible for generating the fixtures that are used in the acceptance tests to verify all implementations.
15
+
Java is the reference implementation in the sense that it is responsible for
16
+
generating the fixtures that are used in the acceptance tests to verify all
17
+
implementations.
14
18
15
19
So your playbook for adding a method would be something like:
16
20
17
21
1. Add the method in `Query.Java` with test(s) in `QueryTest.java`
18
-
2. Extend `QueryAcceptanceTest.java` to include verifications for the new method
19
-
3. Run `QueryAcceptanceTest::updateExpectedQueryResultFiles` to regenerate the fixtures
22
+
2. Extend `QueryAcceptanceTest.java` to include verifications for the new
23
+
method
24
+
3. Run `QueryAcceptanceTest::updateExpectedQueryResultFiles` to regenerate the
25
+
fixtures
20
26
4. Implement other languages
21
27
22
28
## Types
23
29
24
-
Choosing which type to use in another language based on what we did in Java is an inexact science. This table defines all the decisions we've made so far:
30
+
Choosing which type to use in another language based on what we did in Java is
31
+
an inexact science. This table defines all the decisions we've made so far:
0 commit comments