Upgrade djangorestframework
#2589
Conversation
| r'versions', | ||
| VersionViewSet, | ||
| basename='version', | ||
| basename='dandiset-version', |
There was a problem hiding this comment.
Raise ImproperlyConfigured exception if
basenameis not unique [#8438]
I think this is a sensible new name, since the viewsets are nested.
There was a problem hiding this comment.
The reason for this change was that NestedAssetViewSet and AssetViewSet basenames were conflicting. I updated VersionViewSet also, just for consistency.
brianhelba
force-pushed
the
drf-upgrade
branch
from
23a2c13 to
91551d2
Compare
| assert resp.json() == ['Zarr already exists'] | ||
| assert resp.json() == { | ||
| 'non_field_errors': ['The fields dandiset, name must make a unique set.'] | ||
| } |
There was a problem hiding this comment.
This is the new error raised by the serializer?
brianhelba
force-pushed
the
dep-upgrade
branch
5 times, most recently
from
f7a53c7 to
f8e357e
Compare
brianhelba
force-pushed
the
drf-upgrade
branch
2 times, most recently
from
2ba0dd2 to
046381b
Compare
mvandenburgh
force-pushed
the
dep-upgrade
branch
3 times, most recently
from
2b817d8 to
bdf6846
Compare
brianhelba
force-pushed
the
drf-upgrade
branch
from
046381b to
00a57d3
Compare
brianhelba
force-pushed
the
drf-upgrade
branch
from
00a57d3 to
8f28855
Compare
Also rename the `VersionViewSet` for consistency.
The latest DRF now enforces uniqueness constraints in serializer validation, so all other validation should happen at the same time to avoid incorrect error codes being returned.
brianhelba
force-pushed
the
drf-upgrade
branch
from
8f28855 to
24e2ca1
Compare
| return int(data) | ||
| except (ValueError, TypeError): | ||
| self.fail('invalid') |
There was a problem hiding this comment.
As it stands, this validation will miss negative numbers, as well as numbers greater than 6 digits.
| return int(data) | |
| except (ValueError, TypeError): | |
| self.fail('invalid') | |
| data = int(data) | |
| except (ValueError, TypeError): | |
| self.fail('invalid') | |
| if isinstance(data, int) and (data < 1 or data > 999_999): # noqa: PLR2004 | |
| self.fail('invalid') |
| # If this was loaded via ".get_serializer", then the request is available in context | ||
| self.user: User | AnonymousUser | None = ( | ||
| self._context['request'].user if 'request' in self._context else None | ||
| ) |
There was a problem hiding this comment.
I guess the assumption here is that if self._context['request'] is not available, this must be called by internal code, and we're okay with keeping the dandiset queryset as Dandiset.objects.all()?
| dandiset = serializers.PrimaryKeyRelatedField( | ||
| queryset=Dandiset.objects.all(), | ||
| pk_field=DandisetIdentifierField(), | ||
| ) |
There was a problem hiding this comment.
Does this automatically raise an exception if the specified dandiset ID is not found? And if so, what's the response code (seems like it might be 400 instead of 404)?
Fixes #1896