Skip to content

Commit ad3a3f0

Browse files
committed
Make naming of instances consistent with deployed and remove dandi-staging
1 parent 6d1bc06 commit ad3a3f0

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ development command line options.
6161
variable providing the key for a specific known DANDI instance corresponds to the name
6262
of the instance. For example, the environment variable `DANDI_API_KEY` provides the key
6363
for the known instance named `dandi` and the environment variable
64-
`EMBER_SANDBOX_API_KEY` provides the key for the known instance named `ember-sandbox`.
64+
`EMBER_DANDI_SANDBOX_API_KEY` provides the key for the known instance named `ember-sandbox`.
6565
I.e., the environment variable name is the capitalized version of the instance's name
6666
with "-" replaced by "_" suffixed by "_API_KEY". Providing API keys through environment
6767
variables avoids using keyrings, thus making it possible to "temporarily" use another

dandi/consts.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,6 @@ def urls(self) -> Iterator[str]:
123123
"https://dandiarchive.org",
124124
"https://api.dandiarchive.org/api",
125125
),
126-
# Deprecated. Remove early 2026.
127-
# Should come before dandi-sandbox so _rev map does map to sandbox
128-
"dandi-staging": DandiInstance(
129-
"dandi-staging",
130-
"https://sandbox.dandiarchive.org",
131-
"https://api.sandbox.dandiarchive.org/api",
132-
),
133126
"dandi-sandbox": DandiInstance(
134127
"dandi-sandbox",
135128
"https://sandbox.dandiarchive.org",
@@ -150,13 +143,13 @@ def urls(self) -> Iterator[str]:
150143
"https://staging.lincbrain.org",
151144
"https://staging-api.lincbrain.org/api",
152145
),
153-
"ember": DandiInstance(
154-
"ember",
146+
"ember-dandi": DandiInstance(
147+
"ember-dandi",
155148
"https://dandi.emberarchive.org",
156149
"https://api-dandi.emberarchive.org/api",
157150
),
158-
"ember-sandbox": DandiInstance(
159-
"ember-sandbox",
151+
"ember-dandi-sandbox": DandiInstance(
152+
"ember-dandi-sandbox",
160153
"https://apl-setup--ember-dandi-archive.netlify.app/",
161154
"https://api-dandi-sandbox.emberarchive.org/api",
162155
),

dandi/tests/test_dandiapi.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -869,7 +869,7 @@ def test_asset_as_readable_open(new_dandiset: SampleDandiset, tmp_path: Path) ->
869869
("dandi", "DANDI_API_KEY"),
870870
("dandi-api-local-docker-tests", "DANDI_API_LOCAL_DOCKER_TESTS_API_KEY"),
871871
("dandi-sandbox", "DANDI_SANDBOX_API_KEY"),
872-
("ember-dandi-sandbox", "EMBER_SANDBOX_API_KEY"),
872+
("ember-dandi-sandbox", "EMBER_DANDI_SANDBOX_API_KEY"),
873873
],
874874
)
875875
def test_get_api_key_env_var(instance_name: str, expected_env_var_name: str) -> None:

0 commit comments

Comments
 (0)