Skip to content

Commit b5764b4

Browse files
authored
Merge pull request #1491 from yoshi-taka/remove-lodash.keys
chore: remove lodash.keys
2 parents 2375820 + e7367d5 commit b5764b4

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@
161161
"jsonwebtoken": "^9.0.0",
162162
"lodash.includes": "^4.3.0",
163163
"lodash.isobject": "^3.0.2",
164-
"lodash.keys": "^4.0.8",
165164
"lodash.mapvalues": "^4.6.0",
166165
"lodash.memoize": "^4.1.2",
167166
"memfs-or-file-map-to-github-branch": "^1.3.0",

source/platforms/git/gitJSONToGitDSL.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import parseDiff from "parse-diff"
33

44
import includes from "lodash.includes"
55
import isobject from "lodash.isobject"
6-
import keys from "lodash.keys"
76
import memoize from "lodash.memoize"
87

98
import * as jsonDiff from "fast-json-patch"
@@ -144,8 +143,8 @@ export const gitJSONToGitDSL = (gitJSONRep: GitJSONDSL, config: GitJSONToGitDSLC
144143
diff.removed = arrayBefore.filter((o) => !includes(arrayAfter, o))
145144
// Do the same, but for keys inside an object if they both are objects.
146145
} else if (isobject(afterValue) && isobject(beforeValue)) {
147-
const beforeKeys = keys(beforeValue) as string[]
148-
const afterKeys = keys(afterValue) as string[]
146+
const beforeKeys = Object.keys(beforeValue) as string[]
147+
const afterKeys = Object.keys(afterValue) as string[]
149148
diff.added = afterKeys.filter((o) => !includes(beforeKeys, o))
150149
diff.removed = beforeKeys.filter((o) => !includes(afterKeys, o))
151150
}

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5189,11 +5189,6 @@ lodash.isstring@^4.0.1:
51895189
resolved "https://registry.yarnpkg.com/lodash.isstring/-/lodash.isstring-4.0.1.tgz#d527dfb5456eca7cc9bb95d5daeaf88ba54a5451"
51905190
integrity sha512-0wJxfxH1wgO3GrbuP+dTTk7op+6L41QCXbGINEmD+ny/G/eCqGzxyCsh7159S+mgDDcoarnBw6PC1PS5+wUGgw==
51915191

5192-
lodash.keys@^4.0.8:
5193-
version "4.2.0"
5194-
resolved "https://registry.yarnpkg.com/lodash.keys/-/lodash.keys-4.2.0.tgz#a08602ac12e4fb83f91fc1fb7a360a4d9ba35205"
5195-
integrity sha512-J79MkJcp7Df5mizHiVNpjoHXLi4HLjh9VLS/M7lQSGoQ+0oQ+lWEigREkqKyizPB1IawvQLLKY8mzEcm1tkyxQ==
5196-
51975192
lodash.mapvalues@^4.6.0:
51985193
version "4.6.0"
51995194
resolved "https://registry.yarnpkg.com/lodash.mapvalues/-/lodash.mapvalues-4.6.0.tgz#1bafa5005de9dd6f4f26668c30ca37230cc9689c"

0 commit comments

Comments
 (0)