add and fix tests

Author: schultek

build_web_compilers/lib/build_web_compilers.dart

@@ -13,6 +13,6 @@ export 'src/common.dart'
         symbolsExtension;
 export 'src/dev_compiler_builder.dart' show DevCompilerBuilder;
 export 'src/platforms.dart'
-    show dart2jsPlatform, dart2wasmPlatform, ddcPlatform;
+    show dart2jsPlatform, dart2wasmPlatform, ddcPlatform, initializePlatforms;
 export 'src/web_entrypoint_builder.dart'
     show WebCompiler, WebEntrypointBuilder, ddcBootstrapExtension;

build_web_compilers/lib/builders.dart

@@ -9,7 +9,6 @@ import 'package:collection/collection.dart';
 import 'build_web_compilers.dart';
 import 'src/common.dart';
 import 'src/ddc_frontend_server_builder.dart';
-import 'src/platforms.dart';
 import 'src/sdk_js_compile_builder.dart';
 import 'src/sdk_js_copy_builder.dart';
 import 'src/web_entrypoint_marker_builder.dart';

build_web_compilers/lib/src/platforms.dart

@@ -44,11 +44,23 @@ final ddcPlatform = DartPlatform.byName('ddc');
 final dart2jsPlatform = DartPlatform.byName('dart2js');
 final dart2wasmPlatform = DartPlatform.byName('dart2wasm');
 
+bool? _useAdditionalUiLibraries;
+
 /// Registers the platforms with [DartPlatform].
 ///
 /// Must be called before [ddcPlatform], [dart2jsPlatform], or
 /// [dart2wasmPlatform] is used.
 void initializePlatforms([bool useAdditionalUiLibraries = false]) {
+  if (_useAdditionalUiLibraries != null) {
+    if (_useAdditionalUiLibraries != useAdditionalUiLibraries) {
+      throw ArgumentError(
+        'Function initializePlatforms() called multiple times with different '
+        'values. Make sure to call it always with the same value.',
+      );
+    }
+    return;
+  }
+  _useAdditionalUiLibraries = useAdditionalUiLibraries;
   DartPlatform.register('ddc', [
     ..._coreLibraries,
     ..._additionalWebLibraries,

build_web_compilers/pubspec.yaml

@@ -35,6 +35,7 @@ dev_dependencies:
   d:
     path: test/fixtures/d
   dart_flutter_team_lints: ^3.1.0
+  file: ^7.0.1
   test: ^1.16.0
   yaml: ^3.1.0
 

build_web_compilers/test/dart2js_bootstrap_test.dart

@@ -12,6 +12,7 @@ import 'package:logging/logging.dart';
 import 'package:test/test.dart';
 
 void main() {
+  initializePlatforms();
   final platform = dart2jsPlatform;
 
   late StreamSubscription<LogRecord> logSubscription;
@@ -142,4 +143,93 @@ void main() {
       outputs: expectedOutputs,
     );
   });
+
+  test('throws on unsupported platform library imports', () async {
+    final assets = {
+      'a|lib/index.dart': '''
+        import 'dart:io';
+        main() {
+          print('hello world');
+        }
+      ''',
+    };
+    final expectedOutputs = {
+      'a|lib/.dart2js.meta_module.clean': isNotNull,
+      'a|lib/.dart2js.meta_module.raw': isNotNull,
+      'a|lib/index.dart2js.module': isNotNull,
+      'a|lib/index.module.library': isNotNull,
+    };
+    final logs = <LogRecord>[];
+    await testBuilders(
+      [
+        const ModuleLibraryBuilder(),
+        MetaModuleBuilder(platform),
+        MetaModuleCleanBuilder(platform),
+        ModuleBuilder(platform),
+        WebEntrypointBuilder.fromOptions(
+          const BuilderOptions({
+            'compiler': 'dart2js',
+            'native_null_assertions': false,
+          }),
+        ),
+      ],
+      assets,
+      outputs: expectedOutputs,
+      onLog: logs.add,
+    );
+    expect(
+      logs,
+      contains(
+        isA<LogRecord>().having(
+          (r) => r.message,
+          'message',
+          contains(
+            'Skipping compiling a|lib/index.dart with dart2js because some of '
+            'its\ntransitive libraries have sdk dependencies that are not '
+            'supported on this platform:\n\na|lib/index.dart',
+          ),
+        ),
+      ),
+    );
+  });
+
+  test(
+    'ignores unsupported platform library imports when silence flag is set',
+    () async {
+      final assets = {
+        'a|lib/index.dart': '''
+        import 'dart:io';
+        main() {
+          print('hello world');
+        }
+      ''',
+      };
+      final expectedOutputs = {
+        'a|lib/.dart2js.meta_module.clean': isNotNull,
+        'a|lib/.dart2js.meta_module.raw': isNotNull,
+        'a|lib/index.dart.js.map': isNotNull,
+        'a|lib/index.dart.js.tar.gz': isNotNull,
+        'a|lib/index.dart.js': decodedMatches(contains('world')),
+        'a|lib/index.dart2js.module': isNotNull,
+        'a|lib/index.module.library': isNotNull,
+      };
+      await testBuilders(
+        [
+          const ModuleLibraryBuilder(),
+          MetaModuleBuilder(platform),
+          MetaModuleCleanBuilder(platform),
+          ModuleBuilder(platform),
+          WebEntrypointBuilder.fromOptions(
+            const BuilderOptions({
+              'compiler': 'dart2js',
+              'native_null_assertions': false,
+              'silence_unsupported_modules_warnings': true,
+            }),
+          ),
+        ],
+        assets,
+        outputs: expectedOutputs,
+      );
+    },
+  );
 }

build_web_compilers/test/dart2wasm_bootstrap_test.dart

@@ -9,6 +9,7 @@ import 'package:build_web_compilers/build_web_compilers.dart';
 import 'package:test/test.dart';
 
 void main() {
+  initializePlatforms();
   final startingAssets = {
     'a|web/index.dart': '''
         void main() {

build_web_compilers/test/dev_compiler_bootstrap_test.dart

@@ -2,14 +2,18 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:io';
+
 import 'package:build/build.dart';
 import 'package:build_modules/build_modules.dart';
 import 'package:build_test/build_test.dart';
 import 'package:build_web_compilers/build_web_compilers.dart';
 import 'package:build_web_compilers/builders.dart';
+import 'package:file/memory.dart';
 import 'package:test/test.dart';
 
 void main() {
+  initializePlatforms();
   final startingBuilders = {
     // Uses the real sdk copy builder to copy required files from the SDK.
     sdkJsCopyRequirejs(const BuilderOptions({})),
@@ -253,5 +257,27 @@ void main() {
       };
       await testBuilder(builder, sdkAssets, outputs: expectedOutputs);
     });
+
+    test('can use prebuilt sdk from path', () async {
+      final builder = sdkJsCompile(
+        const BuilderOptions({'use-prebuilt-sdk-from-path': 'path/to/sdk'}),
+      );
+      final sdkAssets = <String, Object>{'build_web_compilers|fake.txt': ''};
+      final expectedOutputs = {
+        'build_web_compilers|lib/src/dev_compiler/dart_sdk.js': decodedMatches(
+          'prebuilt-sdk',
+        ),
+        'build_web_compilers|lib/src/dev_compiler/dart_sdk.js.map':
+            decodedMatches('prebuilt-sdk-map'),
+      };
+      final fs = MemoryFileSystem();
+      fs.directory('path/to/sdk')
+        ..createSync(recursive: true)
+        ..childFile('dart_sdk.js').writeAsStringSync('prebuilt-sdk')
+        ..childFile('dart_sdk.js.map').writeAsStringSync('prebuilt-sdk-map');
+      await IOOverrides.runZoned(createFile: fs.file, () async {
+        await testBuilder(builder, sdkAssets, outputs: expectedOutputs);
+      });
+    });
   });
 }

build_web_compilers/test/dev_compiler_builder_test.dart

@@ -11,6 +11,8 @@ import 'package:logging/logging.dart';
 import 'package:test/test.dart';
 
 void main() {
+  initializePlatforms();
+
   group('error free project', () {
     final startingAssets = {
       'a|lib/a.dart': r'''