change naming of unsafe compile option

Author: schultek

build_web_compilers/lib/src/dart2js_bootstrap.dart

@@ -29,7 +29,7 @@ Future<void> bootstrapDart2Js(
   required bool onlyCompiler,
   String entrypointExtension = jsEntrypointExtension,
   String? librariesPath,
-  bool silenceUnsupportedModulesWarnings = false,
+  bool unsafeAllowUnsupportedModules = false,
 }) => _resourcePool.withResource(
   () => _bootstrapDart2Js(
     buildStep,
@@ -38,7 +38,7 @@ Future<void> bootstrapDart2Js(
     onlyCompiler: onlyCompiler,
     entrypointExtension: entrypointExtension,
     librariesPath: librariesPath,
-    silenceUnsupportedModulesWarnings: silenceUnsupportedModulesWarnings,
+    unsafeAllowUnsupportedModules: unsafeAllowUnsupportedModules,
   ),
 );
 
@@ -49,7 +49,7 @@ Future<void> _bootstrapDart2Js(
   required bool onlyCompiler,
   required String entrypointExtension,
   String? librariesPath,
-  bool silenceUnsupportedModulesWarnings = false,
+  bool unsafeAllowUnsupportedModules = false,
 }) async {
   final dartEntrypointId = buildStep.inputId;
   final moduleId = dartEntrypointId.changeExtension(
@@ -65,7 +65,7 @@ Future<void> _bootstrapDart2Js(
     try {
       allDeps = (await module.computeTransitiveDependencies(
         buildStep,
-        throwIfUnsupported: !silenceUnsupportedModulesWarnings,
+        throwIfUnsupported: !unsafeAllowUnsupportedModules,
       ))..add(module);
     } on UnsupportedModules catch (e) {
       final librariesString = (await e.exactLibraries(buildStep).toList())

build_web_compilers/lib/src/dart2wasm_bootstrap.dart

@@ -46,14 +46,14 @@ Future<Dart2WasmBootstrapResult> bootstrapDart2Wasm(
   BuildStep buildStep,
   List<String> additionalArguments,
   String javaScriptModuleExtension, {
-  bool silenceUnsupportedModulesWarnings = false,
+  bool unsafeAllowUnsupportedModules = false,
 }) async {
   return await _resourcePool.withResource(
     () => _bootstrapDart2Wasm(
       buildStep,
       additionalArguments,
       javaScriptModuleExtension,
-      silenceUnsupportedModulesWarnings: silenceUnsupportedModulesWarnings,
+      unsafeAllowUnsupportedModules: unsafeAllowUnsupportedModules,
     ),
   );
 }
@@ -62,7 +62,7 @@ Future<Dart2WasmBootstrapResult> _bootstrapDart2Wasm(
   BuildStep buildStep,
   List<String> additionalArguments,
   String javaScriptModuleExtension, {
-  bool silenceUnsupportedModulesWarnings = false,
+  bool unsafeAllowUnsupportedModules = false,
 }) async {
   final dartEntrypointId = buildStep.inputId;
   final moduleId = dartEntrypointId.changeExtension(
@@ -78,7 +78,7 @@ Future<Dart2WasmBootstrapResult> _bootstrapDart2Wasm(
     try {
       allDeps = (await module.computeTransitiveDependencies(
         buildStep,
-        throwIfUnsupported: !silenceUnsupportedModulesWarnings,
+        throwIfUnsupported: !unsafeAllowUnsupportedModules,
       ))..add(module);
     } on UnsupportedModules catch (e) {
       final librariesString = (await e.exactLibraries(buildStep).toList())

build_web_compilers/lib/src/dev_compiler_bootstrap.dart

@@ -37,7 +37,7 @@ Future<void> bootstrapDdc(
   String entrypointExtension = jsEntrypointExtension,
   required bool? nativeNullAssertions,
   bool usesWebHotReload = false,
-  bool silenceUnsupportedModulesWarnings = false,
+  bool unsafeAllowUnsupportedModules = false,
 }) async {
   // Ensures that the sdk resources are built and available.
   await _ensureResources(buildStep, requiredAssets);
@@ -57,7 +57,7 @@ Future<void> bootstrapDdc(
       module,
       buildStep,
       computeStronglyConnectedComponents: !usesWebHotReload,
-      throwIfUnsupported: !silenceUnsupportedModulesWarnings,
+      throwIfUnsupported: !unsafeAllowUnsupportedModules,
     );
   } on UnsupportedModules catch (e) {
     final librariesString = (await e.exactLibraries(buildStep).toList())

build_web_compilers/lib/src/web_entrypoint_builder.dart

@@ -134,19 +134,19 @@ final class EntrypointBuilderOptions {
   /// If not provided, defaults to "lib/libraries.json" in the sdk directory.
   final String? librariesPath;
 
-  /// Whether or not to silence unsupported modules warnings.
+  /// Whether or not to allow unsupported modules.
   ///
   /// If `true` then native core library imports that are not officially
   /// supported by the current platform will be silently allowed.
-  final bool silenceUnsupportedModulesWarnings;
+  final bool unsafeAllowUnsupportedModules;
 
   EntrypointBuilderOptions({
     required this.compilers,
     this.nativeNullAssertions,
     this.loaderExtension,
     this.usesWebHotReload = false,
     this.librariesPath,
-    this.silenceUnsupportedModulesWarnings = false,
+    this.unsafeAllowUnsupportedModules = false,
   });
 
   factory EntrypointBuilderOptions.fromOptions(BuilderOptions options) {
@@ -160,8 +160,8 @@ final class EntrypointBuilderOptions {
     const loaderOption = 'loader';
     const webHotReloadOption = 'web-hot-reload';
     const librariesPathOption = 'libraries_path';
-    const silenceUnsupportedModulesWarningsOption =
-        'silence_unsupported_modules_warnings';
+    const unsafeAllowUnsupportedModulesOption =
+        'unsafe_allow_unsupported_modules';
     String? defaultLoaderOption;
 
     const supportedOptions = [
@@ -173,7 +173,7 @@ final class EntrypointBuilderOptions {
       loaderOption,
       webHotReloadOption,
       librariesPathOption,
-      silenceUnsupportedModulesWarningsOption,
+      unsafeAllowUnsupportedModulesOption,
       'use-ui-libraries',
     ];
 
@@ -182,8 +182,8 @@ final class EntrypointBuilderOptions {
         options.config[nativeNullAssertionsOption] as bool?;
     final usesWebHotReload = options.config[webHotReloadOption] as bool?;
     final librariesPath = options.config[librariesPathOption] as String?;
-    final silenceUnsupportedModulesWarnings =
-        options.config[silenceUnsupportedModulesWarningsOption] as bool?;
+    final unsafeAllowUnsupportedModules =
+        options.config[unsafeAllowUnsupportedModulesOption] as bool?;
     final compilers = <EnabledEntrypointCompiler>[];
 
     validateOptions(
@@ -272,8 +272,7 @@ final class EntrypointBuilderOptions {
               : defaultLoaderOption,
       usesWebHotReload: usesWebHotReload ?? false,
       librariesPath: librariesPath,
-      silenceUnsupportedModulesWarnings:
-          silenceUnsupportedModulesWarnings ?? false,
+      unsafeAllowUnsupportedModules: unsafeAllowUnsupportedModules ?? false,
     );
   }
 
@@ -363,8 +362,8 @@ class WebEntrypointBuilder implements Builder {
                           ? _ddcLibraryBundleSdkResources
                           : _ddcSdkResources,
                   usesWebHotReload: usesWebHotReload,
-                  silenceUnsupportedModulesWarnings:
-                      options.silenceUnsupportedModulesWarnings,
+                  unsafeAllowUnsupportedModules:
+                      options.unsafeAllowUnsupportedModules,
                 );
               } on MissingModulesException catch (e) {
                 log.severe('$e');
@@ -380,8 +379,8 @@ class WebEntrypointBuilder implements Builder {
               onlyCompiler: options.compilers.length == 1,
               entrypointExtension: compiler.extension,
               librariesPath: options.librariesPath,
-              silenceUnsupportedModulesWarnings:
-                  options.silenceUnsupportedModulesWarnings,
+              unsafeAllowUnsupportedModules:
+                  options.unsafeAllowUnsupportedModules,
             ),
           );
         case WebCompiler.Dart2Wasm:
@@ -391,8 +390,8 @@ class WebEntrypointBuilder implements Builder {
                 buildStep,
                 compiler.compilerArguments,
                 compiler.extension,
-                silenceUnsupportedModulesWarnings:
-                    options.silenceUnsupportedModulesWarnings,
+                unsafeAllowUnsupportedModules:
+                    options.unsafeAllowUnsupportedModules,
               );
             }),
           );

build_web_compilers/test/dart2js_bootstrap_test.dart

@@ -194,7 +194,7 @@ void main() {
   });
 
   test(
-    'ignores unsupported platform library imports when silence flag is set',
+    'ignores unsupported platform library imports when allow flag is set',
     () async {
       final assets = {
         'a|lib/index.dart': '''
@@ -223,7 +223,7 @@ void main() {
             const BuilderOptions({
               'compiler': 'dart2js',
               'native_null_assertions': false,
-              'silence_unsupported_modules_warnings': true,
+              'unsafe_allow_unsupported_modules': true,
             }),
           ),
         ],