-
Notifications
You must be signed in to change notification settings - Fork 57
Open
Description
First of all integration tests are not running as part of pr workflow.
They seem to have been removed in this PR #150
There are also couple of issues when running integration tests:
- Compilation error
error[E0599]: no method named encode_to_vec found for struct arrow_flight::sql::Any in the current scope
--> core/tests/flight/mod.rs:168:67
|
168 | let ticket_payload = TicketStatementQuery::default().as_any().encode_to_vec();
This can be fixed by this change:
- let ticket_payload = TicketStatementQuery::default().as_any().encode_to_vec();
+ let ticket_payload = TicketStatementQuery::default().as_any().value.encode_to_vec();
- The ports are not properly configured during container initialization which makes containers inaccessible. This can be fixed in
core/tests/docker/mod.rs:
- host_port: Some(format!("{host_port}/tcp")),
+ host_port: Some(format!("{host_port}")),
After these two fixes there's a single failure:
failures:
flight::test_flight_sql_data_source
Which happens to be the same test the first issue was in.
Suggested changes:
- Apply two mentioned fixes
- Fix failing
flight::test_flight_sql_data_sourcetest - Make sure integration tests are running as part of pr workflow
Metadata
Metadata
Assignees
Labels
No labels