feat(ui/backend): business attributes support for new ui (#15452)

Author: kartikey-visa

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/entity/EntityPrivilegesResolver.java

@@ -14,6 +14,7 @@
 import com.linkedin.datahub.graphql.generated.Entity;
 import com.linkedin.datahub.graphql.generated.EntityPrivileges;
 import com.linkedin.datahub.graphql.resolvers.assertion.AssertionUtils;
+import com.linkedin.datahub.graphql.resolvers.businessattribute.BusinessAttributeAuthorizationUtils;
 import com.linkedin.datahub.graphql.resolvers.dataproduct.DataProductAuthorizationUtils;
 import com.linkedin.datahub.graphql.resolvers.incident.IncidentUtils;
 import com.linkedin.datahub.graphql.resolvers.mutate.DescriptionUtils;
@@ -52,6 +53,8 @@ public CompletableFuture<EntityPrivileges> get(DataFetchingEnvironment environme
     return GraphQLConcurrencyUtils.supplyAsync(
         () -> {
           switch (urn.getEntityType()) {
+            case Constants.BUSINESS_ATTRIBUTE_ENTITY_NAME:
+              return getBusinessAttributePrivileges(urn, context);
             case Constants.GLOSSARY_TERM_ENTITY_NAME:
               return getGlossaryTermPrivileges(urn, context);
             case Constants.GLOSSARY_NODE_ENTITY_NAME:
@@ -79,6 +82,14 @@ public CompletableFuture<EntityPrivileges> get(DataFetchingEnvironment environme
         "get");
   }
 
+  private EntityPrivileges getBusinessAttributePrivileges(Urn urn, QueryContext context) {
+    final EntityPrivileges result = new EntityPrivileges();
+    result.setCanManageEntity(
+        BusinessAttributeAuthorizationUtils.canManageBusinessAttribute(context));
+    addCommonPrivileges(result, urn, context);
+    return result;
+  }
+
   private EntityPrivileges getGlossaryTermPrivileges(Urn termUrn, QueryContext context) {
     final EntityPrivileges result = new EntityPrivileges();
     addCommonPrivileges(result, termUrn, context);

datahub-graphql-core/src/main/resources/entity.graphql

@@ -13996,6 +13996,11 @@ type BusinessAttribute implements Entity {
   List of relationships between the source Entity and some destination entities with a given types
   """
   relationships(input: RelationshipsInput!): EntityRelationshipsResult
+
+  """
+  Privileges given to a user relevant to this entity
+  """
+  privileges: EntityPrivileges
 }
 
 """

datahub-graphql-core/src/test/java/com/linkedin/datahub/graphql/resolvers/entity/EntityPrivilegesResolverTest.java

@@ -6,6 +6,7 @@
 
 import com.datahub.authentication.Authentication;
 import com.linkedin.datahub.graphql.QueryContext;
+import com.linkedin.datahub.graphql.generated.BusinessAttribute;
 import com.linkedin.datahub.graphql.generated.Chart;
 import com.linkedin.datahub.graphql.generated.Dashboard;
 import com.linkedin.datahub.graphql.generated.DataJob;
@@ -31,6 +32,7 @@ public class EntityPrivilegesResolverTest {
   final String dashboardUrn = "urn:li:dashboard:(looker,dashboards.1)";
   final String dataJobUrn =
       "urn:li:dataJob:(urn:li:dataFlow:(spark,test_machine.sparkTestApp,local),QueryExecId_31)";
+  final String businessAttributeUrn = "urn:li:businessAttribute:testBusinessAttribute";
 
   private DataFetchingEnvironment setUpTestWithPermissions(Entity entity) {
     QueryContext mockContext = getMockAllowContext();
@@ -238,4 +240,77 @@ public void testGetDataJobSuccessWithoutPermissions() throws Exception {
 
     assertFalse(result.getCanEditLineage());
   }
+
+  @Test
+  public void testGetBusinessAttributeSuccessWithPermissions() throws Exception {
+    final BusinessAttribute businessAttribute = new BusinessAttribute();
+    businessAttribute.setUrn(businessAttributeUrn);
+
+    EntityClient mockClient = Mockito.mock(EntityClient.class);
+    DataFetchingEnvironment mockEnv = setUpTestWithPermissions(businessAttribute);
+
+    EntityPrivilegesResolver resolver = new EntityPrivilegesResolver(mockClient);
+    EntityPrivileges result = resolver.get(mockEnv).get();
+
+    assertTrue(result.getCanManageEntity());
+    // Verify common privileges are also set
+    assertTrue(result.getCanEditLineage());
+    assertTrue(result.getCanEditProperties());
+    assertTrue(result.getCanEditTags());
+    assertTrue(result.getCanEditGlossaryTerms());
+    assertTrue(result.getCanEditOwners());
+    assertTrue(result.getCanEditDescription());
+    assertTrue(result.getCanEditLinks());
+  }
+
+  @Test
+  public void testGetBusinessAttributeSuccessWithoutPermissions() throws Exception {
+    final BusinessAttribute businessAttribute = new BusinessAttribute();
+    businessAttribute.setUrn(businessAttributeUrn);
+
+    EntityClient mockClient = Mockito.mock(EntityClient.class);
+    DataFetchingEnvironment mockEnv = setUpTestWithoutPermissions(businessAttribute);
+
+    EntityPrivilegesResolver resolver = new EntityPrivilegesResolver(mockClient);
+    EntityPrivileges result = resolver.get(mockEnv).get();
+
+    assertFalse(result.getCanManageEntity());
+    // Verify common privileges are also denied
+    assertFalse(result.getCanEditLineage());
+    assertFalse(result.getCanEditProperties());
+    assertFalse(result.getCanEditTags());
+    assertFalse(result.getCanEditGlossaryTerms());
+    assertFalse(result.getCanEditOwners());
+    assertFalse(result.getCanEditDescription());
+    assertFalse(result.getCanEditLinks());
+  }
+
+  @Test
+  public void testGetBusinessAttributeWithCommonPrivileges() throws Exception {
+    final BusinessAttribute businessAttribute = new BusinessAttribute();
+    businessAttribute.setUrn(businessAttributeUrn);
+
+    EntityClient mockClient = Mockito.mock(EntityClient.class);
+    DataFetchingEnvironment mockEnv = setUpTestWithPermissions(businessAttribute);
+
+    EntityPrivilegesResolver resolver = new EntityPrivilegesResolver(mockClient);
+    EntityPrivileges result = resolver.get(mockEnv).get();
+
+    // Test that business attribute gets all common privileges
+    assertNotNull(result);
+    assertTrue(result.getCanManageEntity());
+    assertTrue(result.getCanEditLineage());
+    assertTrue(result.getCanEditProperties());
+    assertTrue(result.getCanEditAssertions());
+    assertTrue(result.getCanEditIncidents());
+    assertTrue(result.getCanEditDomains());
+    assertTrue(result.getCanEditDataProducts());
+    assertTrue(result.getCanEditDeprecation());
+    assertTrue(result.getCanEditGlossaryTerms());
+    assertTrue(result.getCanEditTags());
+    assertTrue(result.getCanEditOwners());
+    assertTrue(result.getCanEditDescription());
+    assertTrue(result.getCanEditLinks());
+    assertTrue(result.getCanManageAssetSummary());
+  }
 }

datahub-web-react/src/app/entityV2/Entity.tsx

@@ -105,6 +105,10 @@ export enum EntityCapabilityType {
      * Related context documents for this entity
      */
     RELATED_DOCUMENTS,
+    /**
+     * Adding a business attribute to the entity
+     */
+    BUSINESS_ATTRIBUTES,
 }
 
 export interface EntityMenuActions {

datahub-web-react/src/app/entityV2/businessAttribute/BusinessAttributeEntity.tsx

@@ -9,6 +9,7 @@ import { EntityMenuItems } from '@app/entityV2/shared/EntityDropdown/EntityMenuA
 import { EntityProfile } from '@app/entityV2/shared/containers/profile/EntityProfile';
 import { SidebarAboutSection } from '@app/entityV2/shared/containers/profile/sidebar/AboutSection/SidebarAboutSection';
 import { SidebarOwnerSection } from '@app/entityV2/shared/containers/profile/sidebar/Ownership/sidebar/SidebarOwnerSection';
+import { SidebarGlossaryTermsSection } from '@app/entityV2/shared/containers/profile/sidebar/SidebarGlossaryTermsSection';
 import { SidebarTagsSection } from '@app/entityV2/shared/containers/profile/sidebar/SidebarTagsSection';
 import { getDataForEntityType } from '@app/entityV2/shared/containers/profile/utils';
 import { DocumentationTab } from '@app/entityV2/shared/tabs/Documentation/DocumentationTab';
@@ -128,9 +129,12 @@ export class BusinessAttributeEntity implements Entity<BusinessAttribute> {
                     {
                         component: SidebarTagsSection,
                         properties: {
-                            hasTags: true,
-                            hasTerms: true,
                             customTagPath: 'properties.tags',
+                        },
+                    },
+                    {
+                        component: SidebarGlossaryTermsSection,
+                        properties: {
                             customTermPath: 'properties.glossaryTerms',
                         },
                     },
@@ -149,7 +153,7 @@ export class BusinessAttributeEntity implements Entity<BusinessAttribute> {
             EntityCapabilityType.OWNERS,
             EntityCapabilityType.TAGS,
             EntityCapabilityType.GLOSSARY_TERMS,
-            // EntityCapabilityType.BUSINESS_ATTRIBUTES,
+            EntityCapabilityType.BUSINESS_ATTRIBUTES,
         ]);
     };
 }

datahub-web-react/src/app/entityV2/shared/containers/profile/sidebar/SidebarGlossaryTermsSection.tsx

@@ -7,6 +7,7 @@ import { EMPTY_MESSAGES } from '@app/entityV2/shared/constants';
 import EmptySectionText from '@app/entityV2/shared/containers/profile/sidebar/EmptySectionText';
 import SectionActionButton from '@app/entityV2/shared/containers/profile/sidebar/SectionActionButton';
 import { SidebarSection } from '@app/entityV2/shared/containers/profile/sidebar/SidebarSection';
+import { useEntityDataExtractor } from '@app/entityV2/shared/containers/profile/sidebar/hooks/useEntityDataExtractor';
 import { ENTITY_PROFILE_GLOSSARY_TERMS_ID } from '@app/onboarding/config/EntityProfileOnboardingConfig';
 import AddTagTerm from '@app/sharedV2/tags/AddTagTerm';
 import TagTermGroup from '@app/sharedV2/tags/TagTermGroup';
@@ -22,17 +23,23 @@ const Content = styled.div`
 
 interface Props {
     readOnly?: boolean;
+    properties?: any;
 }
 
-export const SidebarGlossaryTermsSection = ({ readOnly }: Props) => {
+export const SidebarGlossaryTermsSection = ({ readOnly, properties }: Props) => {
     const { entityType, entityData } = useEntityData();
     const refetch = useRefetch();
     const mutationUrn = useMutationUrn();
 
     const [showAddModal, setShowAddModal] = useState(false);
     const [addModalType, setAddModalType] = useState<EntityType | undefined>(undefined);
 
-    const areTermsEmpty = !entityData?.glossaryTerms?.terms?.length;
+    // Extract glossary terms using custom hook
+    const { data: glossaryTerms, isEmpty: areTermsEmpty } = useEntityDataExtractor({
+        customPath: properties?.customTermPath,
+        defaultPath: 'glossaryTerms',
+        arrayProperty: 'terms',
+    });
 
     const canEditTerms = !!entityData?.privileges?.canEditGlossaryTerms;
 
@@ -44,7 +51,7 @@ export const SidebarGlossaryTermsSection = ({ readOnly }: Props) => {
                     <Content>
                         {!areTermsEmpty ? (
                             <TagTermGroup
-                                editableGlossaryTerms={entityData?.glossaryTerms}
+                                editableGlossaryTerms={glossaryTerms}
                                 canAddTerm
                                 canRemove
                                 entityUrn={mutationUrn}

datahub-web-react/src/app/entityV2/shared/containers/profile/sidebar/SidebarTagsSection.tsx

@@ -7,6 +7,7 @@ import { EMPTY_MESSAGES } from '@app/entityV2/shared/constants';
 import EmptySectionText from '@app/entityV2/shared/containers/profile/sidebar/EmptySectionText';
 import SectionActionButton from '@app/entityV2/shared/containers/profile/sidebar/SectionActionButton';
 import { SidebarSection } from '@app/entityV2/shared/containers/profile/sidebar/SidebarSection';
+import { useEntityDataExtractor } from '@app/entityV2/shared/containers/profile/sidebar/hooks/useEntityDataExtractor';
 import { ENTITY_PROFILE_TAGS_ID } from '@app/onboarding/config/EntityProfileOnboardingConfig';
 import AddTagTerm from '@app/sharedV2/tags/AddTagTerm';
 import TagTermGroup from '@app/sharedV2/tags/TagTermGroup';
@@ -22,17 +23,23 @@ const Content = styled.div`
 
 interface Props {
     readOnly?: boolean;
+    properties?: any;
 }
 
-export const SidebarTagsSection = ({ readOnly }: Props) => {
+export const SidebarTagsSection = ({ readOnly, properties }: Props) => {
     const { entityType, entityData } = useEntityData();
     const refetch = useRefetch();
     const mutationUrn = useMutationUrn();
 
     const [showAddModal, setShowAddModal] = useState(false);
     const [addModalType, setAddModalType] = useState<EntityType | undefined>(undefined);
 
-    const areTagsEmpty = !entityData?.globalTags?.tags?.length;
+    // Extract tags using custom hook
+    const { data: tags, isEmpty: areTagsEmpty } = useEntityDataExtractor({
+        customPath: properties?.customTagPath,
+        defaultPath: 'globalTags',
+        arrayProperty: 'tags',
+    });
 
     const canEditTags = !!entityData?.privileges?.canEditTags;
 
@@ -44,7 +51,7 @@ export const SidebarTagsSection = ({ readOnly }: Props) => {
                     <Content>
                         {!areTagsEmpty ? (
                             <TagTermGroup
-                                editableTags={entityData?.globalTags}
+                                editableTags={tags}
                                 canAddTag
                                 canRemove
                                 showEmptyMessage