Refine Azure credential handling in log shipping

potatoqualitee · potatoqualitee · commit aae4e88eec39 · 2025-11-09T15:21:11.000+01:00
Updated logic to only specify AzureCredential for storage account key authentication. For SAS tokens, SQL Server automatically finds the credential by URL, removing unnecessary assignment.
diff --git a/public/Invoke-DbaDbLogShipping.ps1 b/public/Invoke-DbaDbLogShipping.ps1
@@ -1493,12 +1493,10 @@ function Invoke-DbaDbLogShipping {
                                         Type           = "Full"
                                     }
 
-                                    # Explicitly specify Azure credential - use base URL for credential name
+                                    # Only specify credential for storage account key authentication
+                                    # For SAS tokens, SQL Server finds credential automatically by URL
                                     if ($AzureCredential) {
                                         $splatBackup.AzureCredential = $AzureCredential
-                                    } else {
-                                        # For SAS tokens, credential is named after the base URL
-                                        $splatBackup.AzureCredential = $SharedPath
                                     }
 
                                     $LastBackup = Backup-DbaDatabase @splatBackup

Original file line number	Diff line number	Diff line change
`@@ -1493,12 +1493,10 @@ function Invoke-DbaDbLogShipping {`
`1493`	`1493`	`Type = "Full"`
`1494`	`1494`	`}`
`1495`	`1495`
`1496`		`- # Explicitly specify Azure credential - use base URL for credential name`
	`1496`	`+ # Only specify credential for storage account key authentication`
	`1497`	`+ # For SAS tokens, SQL Server finds credential automatically by URL`
`1497`	`1498`	`if ($AzureCredential) {`
`1498`	`1499`	`$splatBackup.AzureCredential = $AzureCredential`
`1499`		`- } else {`
`1500`		`- # For SAS tokens, credential is named after the base URL`
`1501`		`- $splatBackup.AzureCredential = $SharedPath`
`1502`	`1500`	`}`
`1503`	`1501`
`1504`	`1502`	`$LastBackup = Backup-DbaDatabase @splatBackup`