Fix test for Find-DbaOrphanedFile: Support remote instances (#9965)

Author: andreasjordan

tests/Find-DbaOrphanedFile.Tests.ps1

@@ -32,11 +32,10 @@ Describe $CommandName -Tag IntegrationTests {
             $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
             $dbname = "dbatoolsci_orphanedfile_$(Get-Random)"
-            $server = Connect-DbaInstance -SqlInstance $TestConfig.instance2
-            $db1 = New-DbaDatabase -SqlInstance $server -Name $dbname
-
             $dbname2 = "dbatoolsci_orphanedfile_$(Get-Random)"
-            $db2 = New-DbaDatabase -SqlInstance $server -Name $dbname2
+
+            $db1 = New-DbaDatabase -SqlInstance $TestConfig.instance2 -Name $dbname
+            $db2 = New-DbaDatabase -SqlInstance $TestConfig.instance2 -Name $dbname2
 
             $tmpdir = "$($TestConfig.Temp)\orphan_$(Get-Random)"
             if (-not(Test-Path $tmpdir)) {
@@ -63,25 +62,26 @@ Describe $CommandName -Tag IntegrationTests {
 
             $backupFile = Backup-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $dbname -Path $tmpBackupPath -Type Full
             $backupFile2 = Backup-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $dbname2 -Path $tmpBackupPath2 -Type Full
-            Copy-Item -Path $backupFile.BackupPath -Destination "C:\"
 
-            $tmpBackupPath3 = Join-Path (Get-SqlDefaultPaths $server data) "dbatoolsci_$(Get-Random)"
-            $null = New-Item -Path $tmpBackupPath3 -ItemType Directory
+            $tmpBackupPath3 = Join-Path (Get-DbaDefaultPath -SqlInstance $TestConfig.instance2).Data "dbatoolsci_$(Get-Random)"
+            Invoke-Command2 -ComputerName $TestConfig.instance2 -ScriptBlock { $null = New-Item -Path $args -ItemType Directory } -ArgumentList $tmpBackupPath3
 
             # We want to run all commands outside of the BeforeAll block without EnableException to be able to test for specific warnings.
             $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
         }
+
         AfterAll {
             # We want to run all commands in the AfterAll block with EnableException to ensure that the test fails if the cleanup fails.
             $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
+
             Get-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $dbname, $dbname2 | Remove-DbaDatabase
-            Remove-Item $tmpdir -Recurse -Force -ErrorAction SilentlyContinue
-            Remove-Item $tmpdir2 -Recurse -Force -ErrorAction SilentlyContinue
-            Remove-Item "C:\$($backupFile.BackupFile)" -Force -ErrorAction SilentlyContinue
-            Remove-Item $tmpBackupPath3 -Recurse -Force -ErrorAction SilentlyContinue
+            Remove-Item $tmpdir -Recurse -Force
+            Remove-Item $tmpdir2 -Recurse -Force
+            Invoke-Command2 -ComputerName $TestConfig.instance2 -ScriptBlock { Remove-Item -Path $args -Recurse -Force } -ArgumentList $tmpBackupPath3
 
             $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
         }
+
         It "Has the correct properties" {
             $null = Dismount-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $dbname -Force
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2
@@ -91,43 +91,40 @@ Describe $CommandName -Tag IntegrationTests {
             ($results[0].PsObject.Properties.Name | Sort-Object) | Should -Be ($ExpectedProps | Sort-Object)
         }
 
-
         It "Finds two files" {
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2
             $results.Filename.Count | Should -Be 2
         }
 
         It "Finds zero files after cleaning up" {
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2
-            $results.FileName | Remove-Item
+            Invoke-Command2 -ComputerName $TestConfig.instance2 -ScriptBlock { Remove-Item -Path $args } -ArgumentList $results.FileName
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2
             $results.Filename.Count | Should -Be 0
         }
-        It "works with -Recurse" {
+
+        It "works with -Path" {
             "a" | Out-File (Join-Path $tmpdir "out.mdf")
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2 -Path $tmpdir
             $results.Filename.Count | Should -Be 1
+
             Move-Item "$tmpdir\out.mdf" -Destination $tmpdirInner
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2 -Path $tmpdir
             $results.Filename.Count | Should -Be 0
+        }
+
+        It "works with -Recurse" {
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2 -Path $tmpdir -Recurse
             $results.Filename.Count | Should -Be 1
 
-            Copy-Item -Path "$tmpdirInner\out.mdf" -Destination $tmpBackupPath3
-
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2 -Path $tmpdir, $tmpdir2 -Recurse -FileType bak
             $results.Filename | Should -Contain $backupFile.BackupPath
             $results.Filename | Should -Contain $backupFile2.BackupPath
-            $results.Filename | Should -Contain "$tmpdirInner\out.mdf"
-            $results.Filename | Should -Contain "$tmpBackupPath3\out.mdf"
-            $results.Count | Should -Be 4
+            $results.Count | Should -Be 3
 
+            Invoke-Command2 -ComputerName $TestConfig.instance2 -ScriptBlock { "a" | Out-File (Join-Path $args "out.mdf") } -ArgumentList $tmpBackupPath3
             $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2 -Recurse
             $results.Filename | Should -Be "$tmpBackupPath3\out.mdf"
         }
-        It "works with -Path" {
-            $results = Find-DbaOrphanedFile -SqlInstance $TestConfig.instance2 -Path "C:" -FileType bak
-            $results.Filename | Should -Contain "C:\$($backupFile.BackupFile)"
-        }
     }
 }