Merge pull request #170 from dataplat/development

v0.9.2

Author: nvarscar

dbops.psd1

@@ -4,7 +4,7 @@
     RootModule             = '.\dbops.psm1'
 
     # Version number of this module.
-    ModuleVersion          = '0.9.0'
+    ModuleVersion          = '0.9.1'
 
     # ID used to uniquely identify this module
     GUID                   = '16dff216-533a-4fa3-9b2e-4408dbe15e63'

docs/changelog.md

@@ -1,3 +1,5 @@
+# Release notes for v0.9.2:
+- ### Check for empty file when computing hash (#168) by @matthiaslueken
 # Release notes for v0.9.1:
 - ### Update README.md (#156) by @kevchant
 - ### adding AlwaysRollback to deploy.ps1 and module configuration (#157) by @nvarscar

internal/classes/DBOps.class.ps1

@@ -1093,6 +1093,8 @@ class DBOpsFile : DBOps {
     [void] RebuildHash() {
         if ($this.Length -gt 0) {
             $this.Hash = [DBOpsHelper]::ToHexString([Security.Cryptography.HashAlgorithm]::Create("MD5").ComputeHash($this.ByteArray))
+        } else {
+            $this.ThrowException("Hash cannot be computed, file is empty: $($this.Name)", 'InvalidData')
         }
     }
     #Verify that hash is valid

internal/functions/Install-NugetPackage.ps1

@@ -95,7 +95,13 @@ function Install-NugetPackage {
 
         $baseAddressUrl = $index.resources | Where-Object { $_.'@type' -eq 'PackageBaseAddress/3.0.0' } | Select-Object -First 1
         $downloadUrl = "$($baseAddressUrl.'@id')$packageLowerName/$selectedVersion/$fileName"
-        Invoke-WebRequest -Uri $downloadUrl -OutFile $packagePath -ErrorAction Stop
+        try {
+            Invoke-WebRequest -Uri $downloadUrl -OutFile $packagePath -ErrorAction Stop
+        }
+        catch {
+            $originalError = $_.Exception.Message
+            Stop-PSFFunction -Message "Failed to download from $downloadUrl`: $originalError" -EnableException $true
+        }
         Write-PSFMessage -Level Verbose -Message "Extracting $fileName to $folder"
         if ($isCoreCLR) {
             [System.IO.Compression.ZipFile]::ExtractToDirectory($packagePath, $folder, $true)

tests/common/DBOpsFile.class.Tests.ps1

@@ -154,6 +154,10 @@ Describe "DBOpsFile class tests" -Tag UnitTests {
             $file.RebuildHash()
             $file.Hash | Should -Be $oldHash
         }
+        It "should test RebuildHash method with empty file" {
+            $emptyFile = New-Item $workFolder\emptyfile.sql -ItemType File
+            { [DBOpsFile]::new($emptyFile, 'emptyfile.sql', $true) } | Should -Throw
+        }
         It "should test ValidateHash method" {
             $hash = $file.Hash
             { $file.ValidateHash('foo') } | Should -Throw 'File cannot be loaded, hash mismatch*'

tests/compliance/InModule.Help.Tests.ps1

@@ -3,7 +3,7 @@ BeforeDiscovery {
     $includedNames = (Get-ChildItem "$PSScriptRoot\..\..\functions" | Where-Object Name -like "*.ps1" ).BaseName
     $commands = Get-Command -Module (Get-Module dbops) -CommandType Cmdlet, Function | Where-Object Name -in $includedNames
     $commonParameters = 'Debug', 'ErrorAction', 'ErrorVariable', 'InformationAction', 'InformationVariable', 'OutBuffer', 'OutVariable',
-    'PipelineVariable', 'Verbose', 'WarningAction', 'WarningVariable'
+    'PipelineVariable', 'ProgressAction', 'Verbose', 'WarningAction', 'WarningVariable'
     $testCases = $commands | ForEach-Object {
         if ($global:FunctionHelpTestExceptions -contains $_.Name) { continue }
         @{ Command = $_; CommandName = $_.Name; Help = Get-Help $_.Name -ErrorAction SilentlyContinue; Common = $commonParameters }

tests/integration/Install-NugetPackage.Tests.ps1

@@ -40,7 +40,7 @@ Describe "Install-NugetPackage tests" -Tag IntegrationTests {
         It "should attempt to install $d libraries for a wrong version" {
             $dependencies = Get-ExternalLibrary -Type $Type
             foreach ($package in $dependencies) {
-                { Install-NugetPackage -Name $package.Name -RequiredVersion "0.somerandomversion" -Scope CurrentUser -Force -Confirm:$false } | Should -Throw '*Not Found*'
+                { Install-NugetPackage -Name $package.Name -RequiredVersion "0.somerandomversion" -Scope CurrentUser -Force -Confirm:$false } | Should -Throw 'Failed to download*'
                 { Install-NugetPackage -Name $package.Name -MinimumVersion "10.0" -MaximumVersion "1.0" -Scope CurrentUser -Force -Confirm:$false } | Should -Throw '*Version could not be found*'
             }
         }