Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Nov 7, 2025

Proposed changes

  • Updated all storybook dependencies
  • need to add storybook as a dependency to storybooks/angular-storybook/package.json as suggested by the upgrade script
  • the upgrade script reported that the config files weren't valid ESM and further did some the following automigrations

general information

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-upgraded-storybook

@mfranzke mfranzke self-assigned this Nov 7, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Nov 7, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in UX Engineering Team Backlog Nov 7, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: ea3d454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke marked this pull request as ready for review November 7, 2025 15:27
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Nov 7, 2025
@mfranzke mfranzke moved this from 🎁 Ready for review to 🏗 In progress in UX Engineering Team Backlog Nov 9, 2025
@mfranzke mfranzke marked this pull request as draft November 9, 2025 15:07
@mfranzke mfranzke requested a review from Copilot November 9, 2025 15:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Storybook from version 9.1.13 to version 10.0.5 across all storybook configurations in the monorepo. The upgrade includes automated ESM migrations, removal of the eslint-plugin-storybook dependency, and package.json formatting improvements.

  • Upgraded all Storybook packages from 9.1.13 to 10.0.5
  • Applied automated ESM format migrations to main.ts configuration files
  • Removed eslint-plugin-storybook dependency and usage across all storybook packages

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
storybooks/vue-storybook/package.json Updated Storybook dependencies to 10.0.5, removed eslint-plugin-storybook, reordered package.json fields
storybooks/vue-storybook/.storybook/main.ts Added ESM migration with createRequire for module resolution
storybooks/react-storybook/package.json Updated Storybook dependencies to 10.0.5, removed eslint-plugin-storybook
storybooks/react-storybook/eslint.config.js Updated Storybook eslint plugin reference URL and commented out import
storybooks/react-storybook/.storybook/main.ts Added ESM migration with createRequire for module resolution
storybooks/angular-storybook/package.json Updated Storybook dependencies to 10.0.5, added storybook core package
storybooks/angular-storybook/.storybook/main.ts Added ESM migration with createRequire for module resolution
storybooks/_storybook/package.json Updated Storybook dependencies to 10.0.5, removed eslint-plugin-storybook
storybooks/_storybook/eslint.config.js Updated Storybook eslint plugin reference URL and commented out import
storybooks/_storybook/.storybook/main.ts Added ESM migration with createRequire and applied getAbsolutePath to addons
eslint.config.js Added Storybook eslint plugin reference comment (not actively used)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍄🆙improvement New feature or request

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants