Commit fa18e0f
authored
Change "cumulative input is required" error to be a warning (#412)
Towards #387
### Description
Relaxes the validation error for providing no input to a cumulative metric (no measure nor metric) to be a warning instead of an error to avoid breaking changes.
Context: previously, we weren't checking this, so making this an error could break existing manifests that work in general and are being used to run jobs other than this cumulative metric. (The metric will not work in metricflow without an input.)
### Checklist
- [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me
- [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements)
- [x] This PR includes tests, or tests are not required/relevant for this PR
- [x] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)1 parent 004a4ef commit fa18e0f
File tree
3 files changed
+17
-4
lines changed- .changes/unreleased
- dbt_semantic_interfaces/validations
- tests/validations
3 files changed
+17
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1197 | 1197 | | |
1198 | 1198 | | |
1199 | 1199 | | |
1200 | | - | |
| 1200 | + | |
1201 | 1201 | | |
1202 | 1202 | | |
1203 | 1203 | | |
| |||
1209 | 1209 | | |
1210 | 1210 | | |
1211 | 1211 | | |
| 1212 | + | |
1212 | 1213 | | |
1213 | 1214 | | |
1214 | 1215 | | |
| |||
1222 | 1223 | | |
1223 | 1224 | | |
1224 | 1225 | | |
| 1226 | + | |
1225 | 1227 | | |
1226 | 1228 | | |
1227 | 1229 | | |
| |||
1237 | 1239 | | |
1238 | 1240 | | |
1239 | 1241 | | |
| 1242 | + | |
1240 | 1243 | | |
1241 | 1244 | | |
1242 | 1245 | | |
| |||
1246 | 1249 | | |
1247 | 1250 | | |
1248 | 1251 | | |
| 1252 | + | |
1249 | 1253 | | |
1250 | 1254 | | |
1251 | 1255 | | |
| |||
1254 | 1258 | | |
1255 | 1259 | | |
1256 | 1260 | | |
| 1261 | + | |
1257 | 1262 | | |
1258 | 1263 | | |
1259 | 1264 | | |
| |||
1294 | 1299 | | |
1295 | 1300 | | |
1296 | 1301 | | |
1297 | | - | |
1298 | | - | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
1299 | 1306 | | |
1300 | 1307 | | |
1301 | 1308 | | |
| |||
0 commit comments