Remove extra & after stripping internal query params

mislav · mislav · commit c19287e93c96 · 2017-05-20T18:09:35.000+02:00
Before: ?_pjax=1&a=2 => ?&a=2 After: ?_pjax=1&a=2 => ?a=2 Fixes #637, closes #673
diff --git a/jquery.pjax.js b/jquery.pjax.js
@@ -575,7 +575,7 @@ function cloneContents(container) {
 //
 // Returns sanitized url.href String.
 function stripInternalParams(url) {
-  url.search = url.search.replace(/([?&])(_pjax|_)=[^&]*/g, '')
+  url.search = url.search.replace(/([?&])(_pjax|_)=[^&]*/g, '').replace(/^&/, '')
   return url.href.replace(/\?($|#)/, '$1')
 }
 

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ function cloneContents(container) {`
`575`	`575`	`//`
`576`	`576`	`// Returns sanitized url.href String.`
`577`	`577`	`function stripInternalParams(url) {`
`578`		`- url.search = url.search.replace(/([?&])(_pjax\|_)=[^&]*/g, '')`
	`578`	`+ url.search = url.search.replace(/([?&])(_pjax\|_)=[^&]*/g, '').replace(/^&/, '')`
`579`	`579`	`return url.href.replace(/\?($\|#)/, '$1')`
`580`	`580`	`}`
`581`	`581`