Merge pull request #402 from depot/fix/printer-hanging

fix(bake): finish waiting for all printers

Author: goller

pkg/buildx/commands/bake.go

@@ -425,7 +425,9 @@ func BakeCmd() *cobra.Command {
 			err = eg.Wait()
 
 			// Now wait for the printer to finish and flush all output
-			_ = printer.Wait()
+			for range projectIDs {
+				_ = printer.Wait()
+			}
 
 			// Print save help and linter output after all project builds complete
 			for _, result := range buildResults {

pkg/progresshelper/shared.go

@@ -50,10 +50,6 @@ func (w *SharedPrinter) Add() {
 
 func (w *SharedPrinter) Wait() error {
 	w.wg.Done()
-	w.wg.Wait()
-
-	w.cancel()
-
 	lastPrinter := w.numPrinters.Add(-1) == 0
 
 	// The docker progress writer will only return an
@@ -62,6 +58,8 @@ func (w *SharedPrinter) Wait() error {
 	// Only the last printer will be the one to stop the docker printer as
 	// the docker printer closes channels.
 	if lastPrinter {
+		w.wg.Wait()
+		w.cancel()
 		_ = w.printer.Wait()
 	}