Unique constraints duplicate error on v0.9.13

[dev72]

Hello,
my django project is giving me an error starting from v0.9.13:

Traceback (most recent call last):
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/sqlite3/base.py", line 328, in execute
    return super().execute(query, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sqlite3.OperationalError: index labels_cookbook_company_id_name_sv_bd7f95e0_uniq already exists

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/myuser/myproject/run_tests.py", line 21, in <module>
    failures = test_runner.run_tests(['.'])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/test/runner.py", line 1054, in run_tests
    old_config = self.setup_databases(
                 ^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/test/runner.py", line 950, in setup_databases
    return _setup_databases(
           ^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/test/utils.py", line 221, in setup_databases
    connection.creation.create_test_db(
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/base/creation.py", line 78, in create_test_db
    call_command(
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/__init__.py", line 194, in call_command
    return command.execute(*args, **defaults)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/base.py", line 106, in wrapper
    res = handle_func(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/commands/migrate.py", line 321, in handle
    self.sync_apps(connection, executor.loader.unmigrated_apps)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/commands/migrate.py", line 468, in sync_apps
    with connection.schema_editor() as editor:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/sqlite3/schema.py", line 41, in __exit__
    super().__exit__(exc_type, exc_value, traceback)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/base/schema.py", line 166, in __exit__
    self.execute(sql)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/base/schema.py", line 201, in execute
    cursor.execute(sql, params)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 84, in _execute
    with self.db.wrap_database_errors:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/sqlite3/base.py", line 328, in execute
    return super().execute(query, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
django.db.utils.OperationalError: index labels_cookbook_company_id_name_sv_bd7f95e0_uniq already exists
gabriele@darkstar:…/mylabel:develop*:v3.12.9✘ pipenv run python run_tests.py
Found 344 test(s).
Creating test database for alias 'default'...
Traceback (most recent call last):
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/sqlite3/base.py", line 328, in execute
    return super().execute(query, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sqlite3.OperationalError: index labels_menu_company_id_name_sv_3b623427_uniq already exists

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/myuser/myproject/run_tests.py", line 21, in <module>
    failures = test_runner.run_tests(['.'])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/test/runner.py", line 1054, in run_tests
    old_config = self.setup_databases(
                 ^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/test/runner.py", line 950, in setup_databases
    return _setup_databases(
           ^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/test/utils.py", line 221, in setup_databases
    connection.creation.create_test_db(
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/base/creation.py", line 78, in create_test_db
    call_command(
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/__init__.py", line 194, in call_command
    return command.execute(*args, **defaults)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/base.py", line 106, in wrapper
    res = handle_func(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/commands/migrate.py", line 321, in handle
    self.sync_apps(connection, executor.loader.unmigrated_apps)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/core/management/commands/migrate.py", line 468, in sync_apps
    with connection.schema_editor() as editor:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/sqlite3/schema.py", line 41, in __exit__
    super().__exit__(exc_type, exc_value, traceback)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/base/schema.py", line 166, in __exit__
    self.execute(sql)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/base/schema.py", line 201, in execute
    cursor.execute(sql, params)
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 84, in _execute
    with self.db.wrap_database_errors:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/myuser/myproject/.venv/lib/python3.12/site-packages/django/db/backends/sqlite3/base.py", line 328, in execute
    return super().execute(query, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
django.db.utils.OperationalError: index labels_menu_company_id_name_sv_3b623427_uniq already exists

[last-partizan]

Hello.

We have added unique constraints on all translated fields. So, if you have a unique constraint with fields company_id, name, we create unique constraints for all translations as well.

One of your migrations is creating duplicate it seems? Maybe it uses empty string as default, or something like that?

[ukrarome]

I have the same issue on 0.19.13 when run pytest.

ALTER TABLE "app_table" ADD CONSTRAINT "app_table_title_other_kind_id_2f89a748_uniq" UNIQUE ("title_other", "kind_id")
django.db.utils.ProgrammingError: app_table_title_other_kind_id_2f89a748_uniq" already exists

@last-partizan
We have added unique constraints on all translated fields
So here is the problem. While migration same constraints applies twice (django and modeltranslation). Because I already have unique constraints in my model unique_together = ('title', 'kind'). U need to check meta for unique_together before add unique constraints.

I've rollback to 0.19.12 - works fine

[last-partizan]

@ukrarome are you sure it's about "constraints being non-unique", and not about "having an item in the database that violates constraint"?

But, your message is indeed slightly different from the first one.

We're only adding new constraints. E.q for your ('title', 'kind') we add ('title_en', 'kind'), .... Like here: https://github.com/deschler/django-modeltranslation/pull/782/files

Can you show your migrations?

[ukrarome]

@last-partizan yes. I'm sure. As I said I run pytest, DB is empty, it applies migrations, and got error that I already have constraint

ALTER TABLE "app_table" ADD CONSTRAINT "app_table_title_other_kind_id_2f89a748_uniq" UNIQUE ("title_other", "kind_id")
django.db.utils.ProgrammingError: app_table_title_other_kind_id_2f89a748_uniq" already exists

[last-partizan]

Can you please insert print(new_constraint)

In the patch_constraints function, before yield? And show the output.

django-modeltranslation/modeltranslation/translator.py

Line 331 in c4fc8d5

yield new_constraint

Or, prepare a repo with minimal reproduction.

[ukrarome]

@last-partizan U have common mistake in python: referencing to same object. U declare new_constraint before for. And inside for u pointing same object in memory. So each iteration u change same obj and yield it.

def test():
        a = [1, 2]
        for i in [3, 4, 5]:
            a[0] = i
            yield a

tuple(test())
>> ([5, 2], [5, 2], [5, 2])

U need declare list inside for to create new object in memory

def test():
        for i in [3, 4, 5]:
            a = [1, 2]
            a[0] = i
            yield a

tuple(test())
>> ([3, 2], [4, 2], [5, 2])

[last-partizan]

@ukrarome nice catch!

Please test if 785-fix-duplicate-constraint fixes this, and I will merge and release a fix.

[last-partizan]

Fix released.