feat ⭐ make upc optional for product's related models

Author: samar-hassan

oscar_odin/mappings/context.py

@@ -408,7 +408,9 @@ def bulk_update_or_create_many_to_many(self):
                             # Instead of failing bulk_create here below, we will add an error.
                             self.errors.add_error(
                                 OscarOdinException(
-                                    {Through.__name__: f"Cannot create m2m relationship {Through.__name__} - related model '{relation.related_model.__name__}' is missing a primary key"}
+                                    {
+                                        Through.__name__: f"Cannot create m2m relationship {Through.__name__} - related model '{relation.related_model.__name__}' is missing a primary key"
+                                    }
                                 ),
                                 instance,
                             )

oscar_odin/resources/catalogue.py

@@ -89,11 +89,11 @@ class ProductAttributeValueResource(OscarCatalogueResource):
 
 
 class ParentProductResource(OscarCatalogueResource):
-    upc: str
+    upc: Optional[str]
 
 
 class ProductRecommentationResource(OscarCatalogueResource):
-    upc: str
+    upc: Optional[str]
 
 
 class ProductResource(OscarCatalogueResource):

tests/reverse/test_catalogue.py

@@ -677,7 +677,7 @@ def test_recommendation_non_existing(self):
         _, errors = products_to_db(product_resource)
         self.assertEqual(len(errors), 1)
         self.assertEqual(
-            str(errors[0]),
+            str(errors[0].args[0]["ProductRecommendation"]),
             "Cannot create m2m relationship ProductRecommendation - related model 'Product' is missing a primary key",
         )