Syntax warning from ROR check

[timj]

elinkapi/utils.py:5: SyntaxWarning: invalid escape sequence '\/'
  _ROR_ID_PATTERN = re.compile("^(?:(?:(http(s?):\/\/)?(?:ror\.org\/)))?(0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2})$")

This is because it's not a raw string.

This works:

_ROR_ID_PATTERN = re.compile(r"^(?:(?:(http(s?)://)?(?:ror\.org/)))?(0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2})$")

I don't think the / needs to be escaped at all but the "." does.

Example showing it working:

>>> _ROR_ID_PATTERN = re.compile(r"^(?:(?:(http(s?)://)?(?:ror\.org/)))?(0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2})$") 
>>> _ROR_ID_PATTERN.match("https://ror.org/048g3cy84")
<re.Match object; span=(0, 25), match='https://ror.org/048g3cy84'>
>>> _ROR_ID_PATTERN.match("https://ror.org/048g3cy84dfg ")
>>> 

[nensor]

I will be looking into this more; for me it works as is, but perhaps this is a python version thing? Using python3.11, setting using the validation seems to work ok, but will certainly get some unit tests up in there.

That said, doesn't seem to affect anything negatively putting the "r" in there (and removing the escaping forward-slashes), so I will include this as well. My initial tests still seem03fyd9f03 just fine with the example values I have on hand.

>>> from elinkapi import Organization
>>> o = Organization(type="SPONSOR", ror_id = "https://ror.org/01y2jtd41")
>>> o
Organization(type="SPONSOR", name=None, contributor_type=None, identifiers=None, ror_id="https://ror.org/01y2jtd41")
>>> o.ror_id = "03fyd9f03"
>>> o.ror_id
'03fyd9f03'
>>> o.ror_id = "nope"
...
ror_id
  Value error, Invalid ROR ID value. [type=value_error, input_value='nope', input_type=str]

[nensor]

Posted version 0.5.3 to pypi.org for these changes, please let me know if you have any further problems. Thanks!

[timj]

Thank you. I'm sorry, I should have mentioned the python version:

Python 3.12.10 (main, Apr  8 2025, 11:35:47) [Clang 17.0.0 (clang-1700.0.13.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> "\."
<stdin>:1: SyntaxWarning: invalid escape sequence '\.'
'\\.'

[timj]

This works for me. Thank you.