Merge pull request #6 from dolthub/fulghum/finalize

fulghum · web-flow · commit 6799764f2dad · 2025-03-26T17:43:29.000-07:00
bug fix: copy error when closing a runtime
diff --git a/pool.go b/pool.go
@@ -178,7 +178,7 @@ func (pool *Pool) closeRuntime(ctx context.Context, rtrackerIdx int, rtracker *R
 	// We then remove the runtime from the slice
 	newSlice := make([]*RuntimeTracker, len(pool.runtimes)-1)
 	copy(newSlice, pool.runtimes[:rtrackerIdx])
-	copy(newSlice, pool.runtimes[rtrackerIdx+1:])
+	copy(newSlice[rtrackerIdx:], pool.runtimes[rtrackerIdx+1:])
 	pool.runtimes = newSlice
 }
 

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ func (pool Pool) closeRuntime(ctx context.Context, rtrackerIdx int, rtracker R`
`178`	`178`	`// We then remove the runtime from the slice`
`179`	`179`	`newSlice := make([]*RuntimeTracker, len(pool.runtimes)-1)`
`180`	`180`	`copy(newSlice, pool.runtimes[:rtrackerIdx])`
`181`		`- copy(newSlice, pool.runtimes[rtrackerIdx+1:])`
	`181`	`+ copy(newSlice[rtrackerIdx:], pool.runtimes[rtrackerIdx+1:])`
`182`	`182`	`pool.runtimes = newSlice`
`183`	`183`	`}`
`184`	`184`