-
Notifications
You must be signed in to change notification settings - Fork 256
Add custom verifiers to the test project #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b38a95 to
cf4327d
Compare
|
Rebased to no longer depend on #544 |
|
|
||
| namespace $safeprojectname$ | ||
| { | ||
| public static partial class CSharpAnalyzerVerifier<TAnalyzer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have these as source code in the templates instead of adding them the the library itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones in the library cannot be edited as part of the project.
|
I do not understand why these need to be added to the templates |
|
My question still stands: why not just have these types exist in the library itself instead of the templates? |
jmarolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
I answered this in a nested conversation above: #545 (comment) Having these files as an intermediate layer between the analyzer tests and the SDK means users can customize default behavior if the standard defaults don't make sense for the project. Over time, we'll likely move some of the properties people add to this layer back into the library itself, but it's good to have a central point that can be tweaked/modified. |
Add verifier implementations, which are used to customize test framework behavior in the context of a specific analyzer project.