Remove dotnet-format shims #51905
Open
Remove dotnet-format shims #51905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused shim-related configuration properties from the dotnet-format tool project to align with other bundled tools in the SDK. The change eliminates SignableShimRuntimeIdentifiers and PackAsToolShimRuntimeIdentifiers properties that were not being used by other built-in tools like dotnet-watch and Watch.Aspire, improving consistency across the codebase.
- Removes
SignableShimRuntimeIdentifiersproperty (unused throughout the codebase) - Removes
PackAsToolShimRuntimeIdentifiersproperty and its associated comment - Aligns dotnet-format with the packaging approach used by other built-in SDK tools
JoeRobich
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51743
I'm not finding a reason these are needed. We aren't including them in the other bundled tools. Therefore I am proposing we remove them. The size gain is trivial, it is more about cleanliness of not shipping these on non-windows rids.