Update BuildFrameworksTask to build Package.swift directly
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-O objects, headers and modules.
markst
commented
Jul 5, 2024
| version = "4.0.1", | ||
| name = "AFNetworking" | ||
| ) | ||
| /* TODO: Support building target dependencies? i.e `FirebaseCore` & `FirebaseSharedSwift` |
Author
There was a problem hiding this comment.
Packages which have dependencies such as FirebaseRemoteConfig we will need to loop through the dependencies defined in the FIrebase Package.swift. Unless there is another way to identify the dependencies.
Author
There was a problem hiding this comment.
for instance using tool allows to output detailed information about all the linked frameworks:
otool -l ./FirebaseRemoteConfig
Load command 5
cmd LC_LINKER_OPTION
cmdsize 40
count 2
string #1 -framework
string #2 FirebaseCore
string #2 FirebaseCore
Load command 50
cmd LC_LINKER_OPTION
cmdsize 48
count 2
string #1 -framework
string #2 FirebaseSharedSwift
Author
|
Closing in favour of PaGr0m#7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Since
generate-xcodeprojis now deprecated, we need a means to build aXCFrameworkpackaged binary from aPackage.swiftThere is limitation with using
xcodebuildwith Swift package.https://forums.swift.org/t/how-to-build-swift-package-as-xcframework/41414
Based on script shared with this Apple forum:
https://developer.apple.com/forums/thread/741100
This PR will upgrade
BuildFrameworksTaskto build and package XCFramework.PaGr0m#3
https://youtrack.jetbrains.com/issue/KT-53877/Support-Swift-Package-Manager-in-Kotlin-Multiplatform