Skip to content

Commit 361348d

Browse files
github-actions[bot]github-actions[bot]
committed
Merge branch 'release/5.258.0'
2 parents f8c3041 + 4e71a96 commit 361348d

File tree

445 files changed

+18470
-5212
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

445 files changed

+18470
-5212
lines changed

‎.github/actions/assign-release-task/github_asana_mapping.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,4 @@ CrisBarreiro: "1204920898013507"
1313
mikescamell: "1207908161520961"
1414
LukasPaczos: "1208671518759204"
1515
landomen: "1210594645132364"
16+
catalinradoiu: "1211724160828457"

‎.maestro/duckplayer/direct_duckplayer_youtube.yaml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,13 @@ tags:
1818

1919
- runFlow: common/assert_duckplayer_visible.yaml
2020

21-
- tapOn:
22-
id: app
21+
- runFlow:
22+
when:
23+
visible:
24+
id: "global-loader"
25+
commands:
26+
- tapOn:
27+
id: app
2328

2429
- tapOn:
2530
text: "Watch on YouTube"

‎.maestro/fire_button/fire_during_onboarding.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ tags:
2626
- tapOn: "Cancel"
2727
- assertNotVisible: ".*browsing activity with the Fire Button.*"
2828
- runFlow: ../shared/browser_screen/click_on_fire_button.yaml
29-
- tapOn: "Clear All Tabs And Data"
29+
- tapOn: "Clear Tabs and Data"
3030
- assertVisible: "You've got this!.*"

‎.maestro/privacy_tests/14_-_Single-site,_single-tab,_no-session-after-fire.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ tags:
5555
- tapOn: "Copy"
5656
- action: back
5757
- runFlow: ../shared/browser_screen/click_on_fire_button.yaml
58-
- tapOn: "Clear All Tabs And Data"
58+
- tapOn: "Clear Tabs and Data"
5959
- longPressOn:
6060
id: "omnibarTextInput"
6161
- tapOn: "Paste"

‎PixelDefinitions/params_dictionary.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,11 @@
6666
"type": "string",
6767
"description": "Final status of the wide event flow",
6868
"enum": ["SUCCESS", "FAILURE", "CANCELLED", "UNKNOWN"]
69+
},
70+
"source": {
71+
"key": "source",
72+
"type": "string",
73+
"description": "Source from which voice search was launched",
74+
"enum": ["browser", "widget"]
6975
}
7076
}

‎PixelDefinitions/pixels/personal_information_removal.json5‎

Lines changed: 309 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,309 @@
1+
{
2+
"dbp_optout_process_submit-success": {
3+
"description": "Fired when an opt-out submission succeeds.",
4+
"owners": ["karlenDimla", "landomen"],
5+
"triggers": ["other"],
6+
"suffixes": ["form_factor"],
7+
"parameters": [
8+
"appVersion",
9+
{
10+
"key": "data_broker",
11+
"description": "The URL of the data broker that this opt-out attempt targets",
12+
"type": "string"
13+
},
14+
{
15+
"key": "parent",
16+
"description": "The parent data broker of the one this opt-out attempt targets",
17+
"type": "string"
18+
},
19+
{
20+
"key": "attempt_id",
21+
"description": "Client-generated ID of the opt-out attempt",
22+
"type": "string"
23+
},
24+
{
25+
"key": "duration",
26+
"description": "Total duration of the opt-out attempt in milliseconds",
27+
"type": "string"
28+
},
29+
{
30+
"key": "tries",
31+
"description": "The number of tries it took to submit successfully",
32+
"type": "string"
33+
},
34+
{
35+
"key": "pattern",
36+
"description": "Email pattern used during submission, when available",
37+
"type": "string"
38+
},
39+
{
40+
"key": "vpn_connection_state",
41+
"description": "Reported VPN connection state when the submission succeeded",
42+
"type": "string"
43+
},
44+
{
45+
"key": "vpn_bypass",
46+
"description": "VPN bypass status when the submission succeeded",
47+
"type": "string",
48+
"enum": ["on", "off", "unsupported"]
49+
}
50+
]
51+
},
52+
"dbp_optout_process_failure": {
53+
"description": "Fired when an opt-out attempt fails.",
54+
"owners": ["karlenDimla", "landomen"],
55+
"triggers": ["other"],
56+
"suffixes": ["form_factor"],
57+
"parameters": [
58+
"appVersion",
59+
{
60+
"key": "data_broker",
61+
"description": "The URL of the data broker that this opt-out attempt targets",
62+
"type": "string"
63+
},
64+
{
65+
"key": "parent",
66+
"description": "The parent data broker of the one this opt-out attempt targets",
67+
"type": "string"
68+
},
69+
{
70+
"key": "broker_version",
71+
"description": "The version of the broker JSON file",
72+
"type": "string"
73+
},
74+
{
75+
"key": "attempt_id",
76+
"description": "Client-generated ID of the opt-out attempt",
77+
"type": "string"
78+
},
79+
{
80+
"key": "duration",
81+
"description": "Total duration of the opt-out attempt in milliseconds",
82+
"type": "string"
83+
},
84+
{
85+
"key": "stage",
86+
"description": "The stage where the failure occurred",
87+
"type": "string"
88+
},
89+
{
90+
"key": "tries",
91+
"description": "The number of tries recorded when the failure happened",
92+
"type": "string"
93+
},
94+
{
95+
"key": "pattern",
96+
"description": "Email pattern used during the attempt, when available",
97+
"type": "string"
98+
},
99+
{
100+
"key": "action_id",
101+
"description": "Predefined identifier of the broker action that failed",
102+
"type": "string"
103+
},
104+
{
105+
"key": "action_type",
106+
"description": "Type of action that failed",
107+
"type": "string",
108+
"enum": [
109+
"extract",
110+
"navigate",
111+
"fillForm",
112+
"click",
113+
"expectation",
114+
"emailConfirmation",
115+
"getCaptchaInfo",
116+
"solveCaptcha",
117+
"condition"
118+
]
119+
},
120+
{
121+
"key": "vpn_connection_state",
122+
"description": "Reported VPN connection state when the failure happened",
123+
"type": "string"
124+
},
125+
{
126+
"key": "vpn_bypass",
127+
"description": "VPN bypass status when the failure happened",
128+
"type": "string",
129+
"enum": ["on", "off", "unsupported"]
130+
}
131+
]
132+
},
133+
"dbp_databroker_custom_stats_optoutsubmit": {
134+
"description": "Pixel that contains a broker's opt-out 24h submission success rate.",
135+
"owners": ["karlenDimla", "landomen"],
136+
"triggers": ["other"],
137+
"suffixes": ["form_factor"],
138+
"parameters": [
139+
"appVersion",
140+
{
141+
"key": "data_broker",
142+
"description": "The URL of the data broker that this opt-out attempt targets",
143+
"type": "string"
144+
},
145+
{
146+
"key": "optout_submit_success_rate",
147+
"description": "The success rate of how many opt-out jobs successfully requested within 24 hours of creation",
148+
"type": "string"
149+
}
150+
]
151+
},
152+
"dbp_optoutjob_at-7-days_confirmed": {
153+
"description": "Pixel that contains if any submitted opt-out has been confirmed 7 days after submission.",
154+
"owners": ["karlenDimla", "landomen"],
155+
"triggers": ["other"],
156+
"suffixes": ["form_factor"],
157+
"parameters": [
158+
"appVersion",
159+
{
160+
"key": "data_broker",
161+
"description": "The URL of the data broker that has a confirmed opt-out after 7 days",
162+
"type": "string"
163+
}
164+
]
165+
},
166+
"dbp_optoutjob_at-7-days_unconfirmed": {
167+
"description": "Pixel that contains if any submitted opt-out are still unconfirmed 7 days after submission.",
168+
"owners": ["karlenDimla", "landomen"],
169+
"triggers": ["other"],
170+
"suffixes": ["form_factor"],
171+
"parameters": [
172+
"appVersion",
173+
{
174+
"key": "data_broker",
175+
"description": "The URL of the data broker that has an unconfirmed opt-out after 7 days",
176+
"type": "string"
177+
}
178+
]
179+
},
180+
"dbp_optoutjob_at-14-days_confirmed": {
181+
"description": "Pixel that contains if any submitted opt-out has been confirmed 14 days after submission.",
182+
"owners": ["karlenDimla", "landomen"],
183+
"triggers": ["other"],
184+
"suffixes": ["form_factor"],
185+
"parameters": [
186+
"appVersion",
187+
{
188+
"key": "data_broker",
189+
"description": "The URL of the data broker that has a confirmed opt-out after 14 days",
190+
"type": "string"
191+
}
192+
]
193+
},
194+
"dbp_optoutjob_at-14-days_unconfirmed": {
195+
"description": "Pixel that contains if any submitted opt-out are still unconfirmed 14 days after submission.",
196+
"owners": ["karlenDimla", "landomen"],
197+
"triggers": ["other"],
198+
"suffixes": ["form_factor"],
199+
"parameters": [
200+
"appVersion",
201+
{
202+
"key": "data_broker",
203+
"description": "The URL of the data broker that has an unconfirmed opt-out after 14 days",
204+
"type": "string"
205+
}
206+
]
207+
},
208+
"dbp_optoutjob_at-21-days_confirmed": {
209+
"description": "Pixel that contains if any submitted opt-out has been confirmed 21 days after submission.",
210+
"owners": ["karlenDimla", "landomen"],
211+
"triggers": ["other"],
212+
"suffixes": ["form_factor"],
213+
"parameters": [
214+
"appVersion",
215+
{
216+
"key": "data_broker",
217+
"description": "The URL of the data broker that has a confirmed opt-out after 21 days",
218+
"type": "string"
219+
}
220+
]
221+
},
222+
"dbp_optoutjob_at-21-days_unconfirmed": {
223+
"description": "Pixel that contains if any submitted opt-out are still unconfirmed 21 days after submission.",
224+
"owners": ["karlenDimla", "landomen"],
225+
"triggers": ["other"],
226+
"suffixes": ["form_factor"],
227+
"parameters": [
228+
"appVersion",
229+
{
230+
"key": "data_broker",
231+
"description": "The URL of the data broker that has an unconfirmed opt-out after 21 days",
232+
"type": "string"
233+
}
234+
]
235+
},
236+
"dbp_optoutjob_at-42-days_confirmed": {
237+
"description": "Pixel that contains if any submitted opt-out has been confirmed 42 days after submission.",
238+
"owners": ["karlenDimla", "landomen"],
239+
"triggers": ["other"],
240+
"suffixes": ["form_factor"],
241+
"parameters": [
242+
"appVersion",
243+
{
244+
"key": "data_broker",
245+
"description": "The URL of the data broker that has a confirmed opt-out after 42 days",
246+
"type": "string"
247+
}
248+
]
249+
},
250+
"dbp_optoutjob_at-42-days_unconfirmed": {
251+
"description": "Pixel that contains if any submitted opt-out are still unconfirmed 42 days after submission.",
252+
"owners": ["karlenDimla", "landomen"],
253+
"triggers": ["other"],
254+
"suffixes": ["form_factor"],
255+
"parameters": [
256+
"appVersion",
257+
{
258+
"key": "data_broker",
259+
"description": "The URL of the data broker that has an unconfirmed opt-out after 42 days",
260+
"type": "string"
261+
}
262+
]
263+
},
264+
"dbp_engagement_dau": {
265+
"description": "Pixel for PIR daily active users.",
266+
"owners": ["karlenDimla", "landomen"],
267+
"triggers": ["other"],
268+
"suffixes": ["form_factor"],
269+
"parameters": ["appVersion"]
270+
},
271+
"dbp_engagement_wau": {
272+
"description": "Pixel for PIR weekly active users.",
273+
"owners": ["karlenDimla", "landomen"],
274+
"triggers": ["other"],
275+
"suffixes": ["form_factor"],
276+
"parameters": ["appVersion"]
277+
},
278+
"dbp_engagement_mau": {
279+
"description": "Pixel for PIR monthly active users.",
280+
"owners": ["karlenDimla", "landomen"],
281+
"triggers": ["other"],
282+
"suffixes": ["form_factor"],
283+
"parameters": ["appVersion"]
284+
},
285+
"dbp_weekly_child-broker_orphaned-optouts": {
286+
"description": "Pixel to know orphaned opt-out records on child data brokers that don't have matching profiles on their parent broker.",
287+
"owners": ["karlenDimla", "landomen"],
288+
"triggers": ["other"],
289+
"suffixes": ["form_factor"],
290+
"parameters": [
291+
"appVersion",
292+
{
293+
"key": "data_broker",
294+
"description": "The URL of the child data broker site",
295+
"type": "string"
296+
},
297+
{
298+
"key": "child-parent-record-difference",
299+
"description": "(child opt-outs count) - (parent opt-outs count)",
300+
"type": "string"
301+
},
302+
{
303+
"key": "calculated-orphaned-records",
304+
"description": "The Number of child profiles with no parent match",
305+
"type": "string"
306+
}
307+
]
308+
}
309+
}

‎PixelDefinitions/pixels/serp_settings.json5‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
// See https://app.asana.com/1/137249556945/project/1207908166761516/task/1211846254913290
2+
{
3+
"serp_settings_open_hide-ai-generated-images": {
4+
// See DuckChatSettingsViewModel.kt for usage.
5+
"description": "When the `Hide Ai Generated` option is opened and highlighted in SERP settings.",
6+
"owners": ["mikescamell"],
7+
"triggers": ["other"],
8+
"suffixes": ["form_factor"],
9+
"parameters": ["appVersion"]
10+
},
11+
"serp_settings_open_duck-ai": {
12+
// See OpenNativeSettingsHandler.kt for usage.
13+
"description": "When a user clicks the 'Open Duck.AI button' in the SERP settings menu which takes them to AI Features settings page.",
14+
"owners": ["mikescamell"],
15+
"triggers": ["other"],
16+
"suffixes": ["form_factor"],
17+
"parameters": ["appVersion"]
18+
}
19+
}

‎PixelDefinitions/pixels/subscription_pixels.json5‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"subscription_webview_render_process_crash": {
3+
"description": "Fired when a render process crash is reported by the WebView that shows subscription pages.",
4+
"owners": ["lmac012"],
5+
"triggers": ["other"],
6+
"suffixes": ["daily_count_short", "form_factor"],
7+
"parameters": [
8+
"appVersion",
9+
{
10+
"key": "is_repeated",
11+
"description": "Indicates whether this is a repeated crash after a recovery attempt. 'false' for first crash, 'true' for repeated crash.",
12+
"type": "string",
13+
"enum": ["true", "false"]
14+
}
15+
]
16+
}
17+
}

0 commit comments

Comments
 (0)