feat: try_files is not evil for named locations #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author
|
By the way, is |
dvershinin
requested changes
Oct 2, 2025
| return 200 "hi"; | ||
| } | ||
| location /abc { | ||
| try_files "" @say_hi; |
Owner
There was a problem hiding this comment.
try_files is not less evil if it uses a named location. The first args matter: here you are checking for file with empty name… have you confirmed this hack does not do a stat for "" ?
Author
There was a problem hiding this comment.
I believe I did check with gdb to see whether stat was running, but I don't remember; it was so long ago. I no longer have the ability to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.