Skip to content

feat: try_files is not evil for named locations #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: try_files is not evil for named locations #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions gixy/plugins/try_files_is_evil_too.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ class try_files_is_evil_too(Plugin):
directives = ["try_files"]

def audit(self, directive):
found_real_try_files = False
for arg in directive.args:
if arg and not arg.startswith('@'):
found_real_try_files = True
break

if not found_real_try_files:
return

# search for open_file_cache ...; on the same or higher level
open_file_cache = directive.find_single_directive_in_scope("open_file_cache")
if not open_file_cache or open_file_cache.args[0] == "off":
Expand Down
8 changes: 8 additions & 0 deletions tests/plugins/simply/try_files_is_evil_too/try_files_is_evil_too_named_location_fp.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
location @say_hi {
internal;
default_type text/plain;
return 200 "hi";
}
location /abc {
try_files "" @say_hi;
Copy link
Owner

@dvershinin dvershinin Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try_files is not less evil if it uses a named location. The first args matter: here you are checking for file with empty name… have you confirmed this hack does not do a stat for "" ?

Copy link
Author

@MegaManSec MegaManSec Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I did check with gdb to see whether stat was running, but I don't remember; it was so long ago. I no longer have the ability to test.

}