Skip to content

small fixes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2024
Merged

small fixes #36

merged 4 commits into from
Nov 4, 2024

Conversation

@oltolm
Copy link
Contributor

@oltolm oltolm commented Nov 3, 2024

Just a bunch of small fixes

  • fix CMake deprecation warnings
  • fix Qt deprecation warning
  • disable a debug print
  • remove unused includes

@u-235 u-235 merged commit 7c764ec into eBookProjects:master Nov 4, 2024
12 checks passed
@u-235
Copy link
Member

u-235 commented Nov 4, 2024

Hi.
Please don't bunch different things into one request next time. Moreover, the commit with Cmake fixes could be split into three:

  • Minimum version change.
  • Adding WIN32.
  • Changing gitignore.

@oltolm oltolm deleted the fixes branch November 4, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oltolm @u-235