-
-
Notifications
You must be signed in to change notification settings - Fork 40
Fix standardize_info(<fixest>)
#1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @mattansb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves a specific issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug in standardize_info() for fixest models. The changes in R/standardize_info.R are well-implemented, simplifying the code by consistently using insight::get_response(model) to fetch the response variable. This removes the previous conditional logic and reliance on stats::model.frame(), which improves robustness and aligns better with the easystats ecosystem's approach of using insight for model introspection. The changes are correct and improve the code's maintainability. The version bump and changelog update are also appropriate.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
==========================================
+ Coverage 63.36% 63.45% +0.09%
==========================================
Files 194 194
Lines 14648 14679 +31
==========================================
+ Hits 9281 9314 +33
+ Misses 5367 5365 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #1178
Created on 2025-11-13 with reprex v2.1.1