Skip to content

Conversation

@mattansb
Copy link
Member

Fixes #1178

library(fixest)

f1  <- feols(mpg ~ hp | am + cyl, data = mtcars)

parameters::standardize_info(f1)
#>   Parameter    Type        Link Secondary_Parameter EffectSize_Type
#> 1        hp numeric Association                <NA>               r
#>   Deviation_Response_Basic Deviation_Response_Smart Deviation_Basic
#> 1                 6.026948                 6.026948        68.56287
#>   Deviation_Smart Deviation_SDy
#> 1        68.56287     0.1372188

parameters::standardise_parameters(f1, method = "basic")
#> # Standardization method: basic
#> 
#> Parameter | Std. Coef. |         95% CI
#> ---------------------------------------
#> hp        |      -0.50 | [-0.84, -0.16]

Created on 2025-11-13 with reprex v2.1.1

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mattansb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves a specific issue where the parameters package was unable to correctly standardize parameters for models generated by the fixest package. The changes ensure that the standardize_info and standardise_parameters functions now properly support fixest objects, enhancing the package's compatibility and reliability for users working with fixed-effects models.

Highlights

  • Bug Fix: Resolved a critical bug in standardize_info(<fixest>) that previously prevented the standardise_parameters() function from working correctly with fixest models.
  • Code Simplification: Streamlined the response variable extraction logic within standardize_info.default, .std_info_response_smart, and .std_info_response_basic by consistently utilizing insight::get_response(model), removing redundant conditional checks.
  • Version Update: The package version has been incremented from 0.28.2.9 to 0.28.2.10 to reflect this bug fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in standardize_info() for fixest models. The changes in R/standardize_info.R are well-implemented, simplifying the code by consistently using insight::get_response(model) to fetch the response variable. This removes the previous conditional logic and reliance on stats::model.frame(), which improves robustness and aligns better with the easystats ecosystem's approach of using insight for model introspection. The changes are correct and improve the code's maintainability. The version bump and changelog update are also appropriate.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.45%. Comparing base (6ad82d6) to head (f2f6206).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
R/standardize_info.R 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
+ Coverage   63.36%   63.45%   +0.09%     
==========================================
  Files         194      194              
  Lines       14648    14679      +31     
==========================================
+ Hits         9281     9314      +33     
+ Misses       5367     5365       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattansb mattansb merged commit e4f6ad0 into main Nov 16, 2025
17 of 20 checks passed
@mattansb mattansb deleted the fix-std-fixest branch November 16, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request or Bug? standardize_parameters for fixest objects

3 participants